No Code Attached Yet J4 Issue
avatar brianteeman
brianteeman
21 Dec 2019

Steps to reproduce the issue

  1. Create a newsfeed without entering a link
  2. create a newsfeed with an invalid link protocal such as blank://test

Expected result

  1. Required field missing alert on save
  2. Info about incorrect scheme on save

Actual result

  1. message about scheme
  2. message about invalid link but without the scheme information

newsfeed

avatar brianteeman brianteeman - open - 21 Dec 2019
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Dec 2019
avatar Gaurav-Punjabi
Gaurav-Punjabi - comment - 23 Dec 2019

Can i work on this issue?

avatar SharkyKZ
SharkyKZ - comment - 23 Dec 2019

@Gaurav-Punjabi of course. And you don't need to ask for permission. Just be aware that point 1 is a duplicate of #26639 and the solution is discussed there.

avatar Gaurav-Punjabi
Gaurav-Punjabi - comment - 23 Dec 2019

Okay, got it👍.

avatar alikon alikon - change - 26 Dec 2019
Labels Added: J4 Issue
avatar alikon alikon - labeled - 26 Dec 2019
avatar vbv2312
vbv2312 - comment - 8 Jan 2020

which file do we need to look up for this issue ??i am a beginner please help a bit

avatar SharkyKZ
SharkyKZ - comment - 9 Jan 2020

@vbv2312 See #26639.

@Gaurav-Punjabi Are you still working on this?

avatar vbv2312
vbv2312 - comment - 9 Jan 2020

@SharkyKZ thanks but with the help of discussions there i faced issues

  1. i cannot replicate the issues on my system
  2. i did not understand where was that particular code to be found
  3. i don't know how to create a fix on the basis of the comments i got there because they had no end to it .the function joomla.submitform(task,document.getElementbyId()) was called in for all article,newsfeed and user then how come there are differences in the performance ?though i cannot replicate errror yet i am asking my assumptions .
    also can you list some good first bugs that a beginner can look upto to increase the involvement in open source .
    thanks
avatar richard67 richard67 - change - 27 Jan 2020
Status New Confirmed
avatar SharkyKZ
SharkyKZ - comment - 11 Feb 2020

@vbv2312 sorry for late response. This fell off my radar.

  1. Did you click Save and not Save & Close button?
  2. Some of the files concerned are listed in the discussion here #26639 (comment).
  3. Joomla.submitform() is executed but no validation is performed because button lacks form-validation attribute.
avatar AndyGaskell
AndyGaskell - comment - 19 Nov 2020

I was just having a look at the second part of this, which seems to still be an issue. So, from the initial description...

Steps to reproduce the issue

  • create a newsfeed with an invalid link protocol such as blank://test

Expected result

  • Info about incorrect scheme on save

Actual result

  • message about invalid link but without the scheme information

Trying this out in in Joomla 4.0.0 beta5, I can recreate it ok I think.

screengrab_news_feed_27331_a

So I guess it should be pulling in the string...
JLIB_FORM_VALIDATE_FIELD_URL_SCHEMA_MISSING="Invalid URL: URL schema is missing in %1$s. Please add one of the following at the beginning: %2$s."
...rather than the vanilla Invalid field: Link message.

I'll see if I can figure out what this is, the logic seems to be in libraries/src/Form/Rule/UrlRule.php and the form is, i think, defined in administrator/components/com_newsfeeds/forms/newsfeed.xml

avatar brianteeman brianteeman - change - 1 Feb 2022
Status Confirmed Closed
Closed_Date 0000-00-00 00:00:00 2022-02-01 23:16:19
Closed_By brianteeman
Labels Added: No Code Attached Yet
Removed: ?
avatar brianteeman brianteeman - close - 1 Feb 2022

Add a Comment

Login with GitHub to post a comment