J4 Issue ?
avatar brianteeman
brianteeman
21 Dec 2019

Steps to reproduce the issue

use com_finder and check error logs

[Sat Dec 21 13:51:19.834493 2019] [fcgid:warn] [pid 31528:tid 708] [client ::1:52503] mod_fcgid: stderr: PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\\htdocs\\joomla-cms\\libraries\\vendor\\wamania\\php-stemmer\\src\\Utf8.php on line 246, referer: http://localhost/joomla-cms/administrator/index.php?option=com_finder&view=indexer&tmpl=component
[Sat Dec 21 13:51:19.834993 2019] [fcgid:warn] [pid 31528:tid 708] [client ::1:52503] mod_fcgid: stderr: PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\\htdocs\\joomla-cms\\libraries\\vendor\\wamania\\php-stemmer\\src\\Utf8.php on line 262, referer: http://localhost/joomla-cms/administrator/index.php?option=com_finder&view=indexer&tmpl=component
[Sat Dec 21 13:51:19.834993 2019] [fcgid:warn] [pid 31528:tid 708] [client ::1:52503] mod_fcgid: stderr: PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\\htdocs\\joomla-cms\\libraries\\vendor\\wamania\\php-stemmer\\src\\Utf8.php on line 263, referer: http://localhost/joomla-cms/administrator/index.php?option=com_finder&view=indexer&tmpl=component
[Sat Dec 21 13:51:19.834993 2019] [fcgid:warn] [pid 31528:tid 708] [client ::1:52503] mod_fcgid: stderr: PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\\htdocs\\joomla-cms\\libraries\\vendor\\wamania\\php-stemmer\\src\\Utf8.php on line 604, referer: http://localhost/joomla-cms/administrator/index.php?option=com_finder&view=indexer&tmpl=component
[Sat Dec 21 13:51:19.835180 2019] [fcgid:warn] [pid 31528:tid 708] [client ::1:52503] mod_fcgid: stderr: PHP Deprecated:  Array and string offset access syntax with curly braces is deprecated in C:\\htdocs\\joomla-cms\\libraries\\vendor\\wamania\\php-stemmer\\src\\Utf8.php on line 609, referer: http://localhost/joomla-cms/administrator/index.php?option=com_finder&view=indexer&tmpl=component

Based on the description of this vendor library and the lack of updates it looks unlikely that this will be fixed

PHP 7.4 will now deprecate the curly brace syntax for accessing array elements and string offsets and it is expected that support will be completely removed in PHP 8.0.
Ref: https://wiki.php.net/rfc/deprecate_curly_braces_array_access

avatar brianteeman brianteeman - open - 21 Dec 2019
avatar joomla-cms-bot joomla-cms-bot - change - 21 Dec 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 21 Dec 2019
avatar brianteeman brianteeman - change - 21 Dec 2019
The description was changed
avatar brianteeman brianteeman - edited - 21 Dec 2019
avatar HLeithner
HLeithner - comment - 21 Dec 2019

Upgrading to v2 (dev) of wamania/php-stemmer could solve the problem but I'm not sure if the API is compatible

avatar brianteeman
brianteeman - comment - 23 Dec 2019

I have asked the question wamania/php-stemmer#5

avatar brianteeman
brianteeman - comment - 23 Dec 2019

@HLeithner positive reply from upstream. Can you take over that please?

avatar HLeithner
HLeithner - comment - 24 Dec 2019

thx, will do

avatar alikon alikon - change - 26 Dec 2019
Labels Added: J4 Issue
avatar alikon alikon - labeled - 26 Dec 2019
avatar HLeithner
HLeithner - comment - 27 Dec 2019

@brianteeman waiting for upstream merging my PR wamania/php-stemmer#6

avatar wamania
wamania - comment - 16 Jan 2020

Hi,
Sorry for the delay, tag 1.3 contains this PR
Thanks HLeithner

avatar brianteeman
brianteeman - comment - 16 Jan 2020

Thanks

avatar wamania
wamania - comment - 16 Jan 2020

FYI v2 will be compatible, but calling the stemmer directly will be deprecated, i would like to force using a factory.

avatar HLeithner HLeithner - close - 19 Jan 2020
avatar HLeithner
HLeithner - comment - 19 Jan 2020

Closing this because we have a PR #27568

avatar HLeithner HLeithner - change - 19 Jan 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-01-19 12:06:56
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 19 Jan 2020

Thanks @wamania for your library and your help

Add a Comment

Login with GitHub to post a comment