Joomla! Issue Tracker | Joomla! CMS #27327 - [4.0] readmore with php7.4

Closed
19 Mar 2020
Medium
Build: 4.0-dev
# 27327
Diff
brianteeman:readmore

Pending

Pending Hound Hound is busy sniffing around... Details

User tests: Successful: Unsuccessful:

brianteeman
20 Dec 2019

Pull request for #27239

Fixes a b/c breaking change from php 7.4

Steps to reproduce the issue

Create a new article with full php errors displayed using php7.4

Actual result

Notice: Trying to access array offset on value of type null in C:\htdocs\joomla-cms\plugins\editors-xtd\readmore\readmore.php on line 52

After applying the PR the notice is gone and readmore plugin works normally

f73a440 20 Dec 2019

[4.0] readmore with php7.4

brianteeman - open - 20 Dec 2019

brianteeman - change - 20 Dec 2019

Status

New

⇒

Pending

joomla-cms-bot - change - 20 Dec 2019

Category

⇒

Front End Plugins

007d5a4 21 Dec 2019

Merge branch '4.0-dev' into readmore

brianteeman - change - 21 Dec 2019

Labels

Added: ?

jwaisner - test_item - 4 Jan 2020 - Tested successfully

jwaisner - comment - 4 Jan 2020

I have tested this item ✅ successfully on 007d5a4

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27327.}

0ed50ca 12 Jan 2020

Update readmore.php

22cd67c 12 Jan 2020

Revert "Update readmore.php"

jwaisner - test_item - 13 Jan 2020 - Tested successfully

jwaisner - comment - 13 Jan 2020

I have tested this item ✅ successfully on 22cd67c

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27327.}

Fedik - comment - 20 Jan 2020

A whole ondDisplay are wrong. The thing that there no event getContent:
$getContentResult = $this->getDispatcher()->dispatch('getContent', $event);

getContent is not an event, and never was, it was editor "method", compare to Joomla 3:

joomla-cms/plugins/editors-xtd/readmore/readmore.php

Lines 41 to 47 in 2d1ea69

    
           		JFactory::getDocument()->addScriptOptions( 
        
           			'xtd-readmore', 
        
           			array( 
        
           				'editor' => $this->_subject->getContent($name), 
        
           				'exists' => JText::_('PLG_READMORE_ALREADY_EXISTS', true), 
        
           			) 
        
           		);

there we have $this->_subject that is Editor instance, if I right remember.

Need to review whole plugin.

no-matter-0 - comment - 23 Feb 2020

same error here

joomla-cms-bot - change - 19 Mar 2020

Closed_By

Quy

⇒

joomla-cms-bot

joomla-cms-bot - close - 19 Mar 2020

Quy - change - 19 Mar 2020

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2020-03-19 23:43:57
Closed_By		⇒	Quy

joomla-cms-bot - comment - 19 Mar 2020

Set to "closed" on behalf of @Quy by The JTracker Application at issues.joomla.org/joomla-cms/27327

Quy - comment - 19 Mar 2020

Closing per PR #28401

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27327.}

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#27327] - [4.0] readmore with php7.4

Steps to reproduce the issue

Actual result

Add a Comment

	JFactory::getDocument()->addScriptOptions(
	'xtd-readmore',
	array(
	'editor' => $this->_subject->getContent($name),
	'exists' => JText::_('PLG_READMORE_ALREADY_EXISTS', true),
	)
	);