With one language, the language header is clickable but not in the dropdown.

Don't think I can really do anything about that other than remove all language sorting. It's really a clustrfck the way languages are in this component

I have tested this item ? unsuccessfully on 5384221

Sort id's not working.

com_config.test_mail still at top with multiple id's (Kunena 6.0 nightly builds has 3 records)

conflicts resolved

any reason why this isnt being merged?

still not working for me the sorting.

i can see the problem but I cant see the fix :(

Hi Brian
I'm sorry, but I'm a little confused here.

• if i click on arrow near by "id" i see that the arrow change and also change the text in the box
  

• if i click on arrow near by "templates" i see that the arrow change

• in language sort if i choose "ALL" i see the text "No Matching Results" but there is the default one installed
  

• In the ID field I see that "com_config.test_mail" appears instead of a number
  in the template column see that the English flag appears, but I think the correct label is "language"
  

• i cannot view any arrow near by the component label
  

could you please help me ?

thanks a lot
Davide

I apologyze it seems that i've done some error in using the editor hopefully now it will be more clear

Hi Brian
I'm sorry, but I'm a little confused here.

.: ** ## if i click on arrow near by "id" i see that the arrow change and also change the text in the box**

.: ** ## if i click on arrow near by "templates" i see that the arrow change**

.: ** ## in language sort if i choose "ALL" i see the text "No Matching Results" but there is the default one installed**

.: ** ## In the ID field I see that "com_config.test_mail" appears instead of a number**

.: ** ## in the template column see that the English flag appears, but I think the correct label is "language"**

.: ** ## i cannot view any arrow near by the component label**

could you please help me ?

thanks a lot
Davide

I have tested this item ✅ successfully on 80d780c

The sorting works according to the changes in arrows and Sort Table drop-down. I think that whether the ID should be a number is a separate issue.

After apply this path I see that I can order by template and id. But if I click on column header, I can see page reloading but order doesn't change.

I have tested this item ✅ successfully on 80d780c

@brianteeman Can you please fix the conflicts?

Closing as cant be fixed without rewriting the component

RE-opened and conflicts fixed as requested

@brianteeman Could you please try this PR brianteeman#120 on your branch? I think it should handle ordering of mail templates properly with that change

@brianteeman Please review and merge this PR brianteeman#121 . After that, I think we are done with this PR

@joomdonation Now there is only sorting on the ID. Why not on the component and title?

@brianteeman That's by design of this component. We store language item in database (I think you looked at the data in table #__mail_templates already), however, what is being displayed is language data from language files (for these columns)

So if we sort by these columns, the data will be stored by language key, while what users see is actually the translated language item and they will see that it is not in right order. I hope I understand and explain it clear enough.

That's why I closed this originally

Closing as cant be fixed without rewriting the component

I dont really consider removing the sorting as a fix.

But could you check workflows please as I am pretty sure that also stores language constants inthe database and still has sorting

To be more clear, if we make the Title column sortable, the system will sort data base on language key such as COM_ACTIONLOGS_EMAIL_SUBJECT, COM_CONFIG_SENDMAIL_SUBJECT... instead of what is being displayed to end users at the moment Actionlogs: Notification Mail, Global Configuration: Test Mail ....

This is something I'm afraid of we could not fix.

For now, maybe we can leave this PR as how it is. At least the sort by ID column works properly now. If we can come up with a solution for sorting other columns, we can open another PR in the future.

I suppose this at least works even if it is not optimal.

Agree. Maybe you can update testing instructions so that we can test this PR and get it merged?

done

I have tested this item ✅ successfully on 82fcc91

I have tested this item ✅ successfully on 82fcc91

RTC

Thanks!

thanks everyone