?
avatar ReLater
ReLater
18 Dec 2019

I really don't know if it's worth to change something here. Pedantry...

Steps to reproduce the issue

  • Install J3 and set language to de-DE for install process.
  • In databse settings fill all fields but clear the table prefix field.
  • Try to go to next installation step.

You'll see an alert (language string INSTL_DATABASE_PREFIX_MSG) that says:

Der Tabellenpräfix muss mit einem Buchstaben beginnen, danach können optional alphanumerische Zeichen und ein Unterstrich folgen.

(EN counterpart:
The table prefix must start with a letter, be followed by optional alphanumeric characters and by an underscore
)

  • At least the German text suggests that the underscore is optional, too.
avatar ReLater ReLater - open - 18 Dec 2019
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Dec 2019
avatar brianteeman
brianteeman - comment - 18 Dec 2019

@Bakual one for you

avatar zero-24
zero-24 - comment - 18 Dec 2019

@ReLater hmm I'm not an regex pro but it does not seam to be required:

if (!preg_match('#^[a-zA-Z]+[a-zA-Z0-9_]*$#', $options->db_prefix))

Demo
https://3v4l.org/SD0XE

avatar ReLater
ReLater - comment - 18 Dec 2019

It's required. I've tested it without underscore.

See also description of the related input field: https://github.com/joomla/joomla-cms/blob/staging/installation/language/de-DE/de-DE.ini#L44

enthält nur alphanumerische Zeichen und MUSS mit einem Unterstrich enden.

I think it's a JS thing or client-site input validation but ???.

avatar zero-24
zero-24 - comment - 18 Dec 2019

Well than please send an issue / PR against https://github.com/joomlagerman/joomla so we make it more clear that the underscore is required in that string too. Any changes in the official language repo gets synced back in here.

avatar ReLater
ReLater - comment - 18 Dec 2019
avatar ReLater ReLater - close - 18 Dec 2019
avatar ReLater ReLater - change - 18 Dec 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-12-18 19:35:35
Closed_By ReLater
avatar zero-24
zero-24 - comment - 18 Dec 2019

Thanks @ReLater

Add a Comment

Login with GitHub to post a comment