? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
18 Dec 2019

Pull Request for Issue #26887 .

Summary of Changes

Fixes the fluid with option in cassiopeia template settings.

Testing Instructions

Apply patch and run node build.js --compile-css to update the changed SCSS.

Enable 'Fluid Width' option in template settings. Check frontend.

Before

image

After

image

Documentation Changes Required

avatar ciar4n ciar4n - open - 18 Dec 2019
avatar ciar4n ciar4n - change - 18 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Dec 2019
Category Front End Templates (site)
avatar ciar4n
ciar4n - comment - 18 Dec 2019

I think this issue came about when removing the IE11 fallback, the fluid width was not considered (I'm guessing by me).

avatar SharkyKZ SharkyKZ - test_item - 19 Dec 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 19 Dec 2019

I have tested this item successfully on 3617771


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27301.

avatar alikon alikon - test_item - 19 Dec 2019 - Tested successfully
avatar alikon
alikon - comment - 19 Dec 2019

I have tested this item successfully on 3617771


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27301.

avatar alikon alikon - change - 19 Dec 2019
Status Pending Ready to Commit
avatar alikon
alikon - comment - 19 Dec 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27301.

avatar infograf768 infograf768 - change - 19 Dec 2019
Labels Added: ? ?
avatar ghazal ghazal - test_item - 19 Dec 2019 - Tested successfully
avatar ghazal
ghazal - comment - 19 Dec 2019

I have tested this item successfully on 648199c

Do not remove "installation" folder, as I did, or else running node command will not work.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27301.

avatar wilsonge wilsonge - change - 23 Dec 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-12-23 12:24:40
Closed_By wilsonge
avatar wilsonge wilsonge - close - 23 Dec 2019
avatar wilsonge wilsonge - merge - 23 Dec 2019
avatar wilsonge
wilsonge - comment - 23 Dec 2019

Thanks!

Add a Comment

Login with GitHub to post a comment