[#27294] - [4.0] Update Bootstrap to 4.4.1
- Fixed in Code Base
- 16 Jan 2020
- Medium
- Build: 4.0-dev
- # 27294
- Diff
- SharkyKZ:j4/npm/bootstrap-4.4.1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27287.
Summary of Changes
Updates Bootstrap from 4.3.1 to 4.4.1 and Popper.js from 1.15.0 to 1.16.0.
Testing Instructions
Run npm install.
Browse around frontend and backend.
Check that styling still OK.
Check that Bootstrap JS components (modal, dropdowns, popovers) still work.
Expected result
Works.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
Depends on the package. Some are locked to the last release of a major version (e.g. Punycode). And some may introduce B/C breaks even in minor releases. I think that's why chosen-js is locked to 1.6.2?
If they dont follow semantic versioning eg chosen then that make sense
But then we have others which do follow semantic versioning such as tinymce which are "locked" at a patch release.
The entire point of using npm is that we shouldnt need to be manually checking all external scripts for updates
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27294.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27294.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27294.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-16 12:03:41 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I think it largely depends on the product. As we know ourselves - some people claim to do semver but not :) I think we're good in most places to allow patch and minors in our package.json as the general rule tho
There are quite a few other npm resources that are "hard coded" to a specific release that are now outdated. Is there a policy on how we handle this. Should all npm resources be set to update automatically