[#27276] - [4.0] Fix language override search
- Fixed in Code Base
- 15 Dec 2019
- Medium
- Build: 4.0-dev
- # 27276
- Diff
- Bakual:40FixLangOverideIndexer
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27275
Summary of Changes
The Language Override Manager didn't recognise the non-prefixed language files.
This PR changes the language file loading logic in the StringsModel->refresh() function so it doesn't require a prefix anymore. It now just loads all INI files in a specific folder.
Testing Instructions
Try to create a new language override and check in the search if the string appears. Eg search fo "Articles" which should yield you several results for en-GB in the administrator client.
Expected result
Search yields all appropriate results.
Actual result
Search yields only results from files that are language prefixed. In core that is only the sampledata testing plugin.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_languages |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27276.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27276.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-15 10:48:34 |
| Closed_By | ⇒ | infograf768 | |
| Labels |
Added:
?
|
||
Tks.
@Bakual @infograf768 isn't this something that needs to be backported to 3.10 too?
Would not hurt, but not absolutely necessary imho as prefixes are still used in 3.9.10
I have tested this item✅ successfully on 7a6dc8e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27276.