[#27271] - [4.0] [php 7.4] ftp upload
- Closed
- 14 Dec 2019
- Medium
- Build: 4.0-dev
- # 27271
- Diff
- brianteeman:ftp
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Under php 7.4 this fixes two errors
The first is
Notice: Trying to access array offset on value of type bool in C:\htdocs\joomla-cms\administrator\components\com_joomlaupdate\View\Joomlaupdate\HtmlView.php on line 142
The second is seen when ftp is selected in the joomla update component in each field
<br /><b>Notice</b>: Trying to access array offset on value of type bool in <b>C:\htdocs\joomla-cms\administrator\components\com_joomlaupdate\tmpl\joomlaupdate\default_upload.php</b> on line <b>101</b><br />
@SharkyKZ @Quy @wilsonge Your expert code review on this would be greatly appreciated. Maybe there is a better way to do this.
Additional comments
- This needs backporting to j3
- I suspect that there will be a lot more of these to fix
- php unit should be updated to test and verify these
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
grrh - I didnt see that and no one commented on the issue I opened :(
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-14 22:10:51 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
This is already fixed in staging. See #27219.