? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Dec 2019

PR for #20312

As @infograf768 pointed out these can never be used in the installer

avatar brianteeman brianteeman - open - 13 Dec 2019
avatar brianteeman brianteeman - change - 13 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Dec 2019
Category Installation Language & Strings
avatar dgrammatiko
dgrammatiko - comment - 13 Dec 2019

@brianteeman this is wrong. The strings are for the Form Field Password and are required for the javascript part that does the check against the requirements (for the installation I think we hardcoded some, but for the rest front end/backend are configurable via the com_user, might be wrong for the component here, have to actually check). So all and all these strings are part of the password form field, if the team that did the last update in the template removed that functionality then they might appear as useless but ARE NOT.

avatar dgrammatiko
dgrammatiko - comment - 13 Dec 2019

@brianteeman this is wrong. The strings are for the Form Field Password and are required for the javascript part that does the check against the requirements (for the installation I think we hardcoded some, but for the rest front end/backend are configurable via the com_user, might be wrong for the component here, have to actually check). So all and all these strings are part of the password form field, if the team that did the last update in the template removed that functionality then they might appear as useless but ARE NOT.

avatar brianteeman
brianteeman - comment - 13 Dec 2019

@dgrammatiko

(for the installation I think we hardcoded some, but for the rest front end/backend are configurable via the com_user, might be wrong for the component here, have to actually check).

Please do check because I couldnt see any

avatar dgrammatiko
dgrammatiko - comment - 13 Dec 2019

There few parts here:

  • the password field at it's current state is not ok, needs #23215
  • This section
    if (Factory::getApplication()->get('db') != '')
    {
    $this->minLength = (int) ComponentHelper::getParams('com_users')->get('minimum_length', 4);
    $this->minIntegers = (int) ComponentHelper::getParams('com_users')->get('minimum_integers', 0);
    $this->minSymbols = (int) ComponentHelper::getParams('com_users')->get('minimum_symbols', 0);
    $this->minUppercase = (int) ComponentHelper::getParams('com_users')->get('minimum_uppercase', 0);
    $this->minLowercase = (int) ComponentHelper::getParams('com_users')->get('minimum_lowercase', 0);
    in the field controls the behaviour specifically for the installation, eg only thing we check is that the password cannot be less than 4 characters.
  • The last update of the template had nothing changed regarding this, so if anyone got offended by this comment, I do apologise :(
avatar brianteeman
brianteeman - comment - 13 Dec 2019

That's my point - the strings are not being used in the installer

avatar brianteeman brianteeman - change - 13 Dec 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-12-13 18:59:26
Closed_By brianteeman
Labels Added: ? ?
avatar brianteeman brianteeman - close - 13 Dec 2019

Add a Comment

Login with GitHub to post a comment