User tests: Successful: Unsuccessful:
PR for #20312
As @infograf768 pointed out these can never be used in the installer
Status | New | ⇒ | Pending |
Category | ⇒ | Installation Language & Strings |
@brianteeman this is wrong. The strings are for the Form Field Password and are required for the javascript part that does the check against the requirements (for the installation I think we hardcoded some, but for the rest front end/backend are configurable via the com_user, might be wrong for the component here, have to actually check). So all and all these strings are part of the password form field, if the team that did the last update in the template removed that functionality then they might appear as useless but ARE NOT.
(for the installation I think we hardcoded some, but for the rest front end/backend are configurable via the com_user, might be wrong for the component here, have to actually check).
Please do check because I couldnt see any
There few parts here:
joomla-cms/libraries/src/Form/Field/PasswordField.php
Lines 163 to 169 in b8bc589
That's my point - the strings are not being used in the installer
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-13 18:59:26 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
?
?
|
@brianteeman this is wrong. The strings are for the Form Field Password and are required for the javascript part that does the check against the requirements (for the installation I think we hardcoded some, but for the rest front end/backend are configurable via the com_user, might be wrong for the component here, have to actually check). So all and all these strings are part of the password form field, if the team that did the last update in the template removed that functionality then they might appear as useless but ARE NOT.