Conflicting Files ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
11 Dec 2019

Summary of Changes

The border colour of the appended button on the search button in the admin should not have a different colour to the rest of the button

Before

image

After

image

avatar brianteeman brianteeman - open - 11 Dec 2019
avatar brianteeman brianteeman - change - 11 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2019
Category Administration Templates (admin)
avatar ciar4n
ciar4n - comment - 11 Dec 2019

This changes the border color to grey? The button color is primary (dark blue).

avatar brianteeman
brianteeman - comment - 11 Dec 2019

Yes that is correct because imho it is not a regular button but part of the larger search element in the same way that the dropdown indicator is styled

image

avatar ciar4n
ciar4n - comment - 12 Dec 2019

Yes that is correct because imho it is not a regular button but part of the larger search element in the same way that the dropdown indicator is styled

I see your point but have to disagree. A dropdown indicator is part of a field and indicates how a user selects an option from that field. A button in a search group is a separate element (consider tab indexing). They are only really grouped for aesthetics. Consider Bootstraps default styling for these elements (same is true for most frameworks)...

image

Personally I think the issue here is how Joomla 4s dropdowns are designed to look like form groups.

Aesthetically I also think that considering the background is also often gray, at first glance the search button looks incorrectly sized.

avatar brianteeman
brianteeman - comment - 12 Dec 2019

They are only really grouped for aesthetics.

Hence this pull request

avatar ciar4n
ciar4n - comment - 12 Dec 2019

Then apply the button background color (--atum-bg-dark) to the border color (https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_buttons.scss#L6).

The grey border is lost on the grey background and just looks like the button is 2px smaller than the input.

avatar brianteeman
brianteeman - comment - 12 Dec 2019

Then apply the button background color (--atum-bg-dark) to the border color

Then it would apply to all buttons and not just this appended button

just looks like the button is 2px smaller than the input.

I dont see that

avatar ciar4n
ciar4n - comment - 12 Dec 2019

Then it would apply to all buttons and not just this appended button

As it should. We don't need to micro style the button for every single use case. It just results in bloated, difficult to maintain css. Not to mention an irregular design across the ui. The whole point of using bootstrap was to avoid this.

avatar brianteeman
brianteeman - comment - 12 Dec 2019

So I can't "micro style" but everyone else can :sigh:

avatar ciar4n
ciar4n - comment - 12 Dec 2019

Seems like we can't discuss the best approach here either. Do as you wish. I'm out.

avatar jwaisner jwaisner - test_item - 7 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 7 Jan 2020

I have tested this item successfully on a8bc8be


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27241.

avatar brianteeman
brianteeman - comment - 9 Jan 2020

Closed see #27458

avatar brianteeman brianteeman - change - 9 Jan 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-01-09 20:37:59
Closed_By brianteeman
Labels Added: Conflicting Files ?
avatar brianteeman brianteeman - close - 9 Jan 2020

Add a Comment

Login with GitHub to post a comment