? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
11 Dec 2019

Summary of Changes

Adds parameterized queries and cleans up SQL in backend part of com_banners.

Testing Instructions

Use com_banners in every way, e.g. view/create/edit/filter/order banners and clients.
Create some banners. Check that their statistics update in backend, etc.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 11 Dec 2019
avatar SharkyKZ SharkyKZ - change - 11 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Dec 2019
Category Administration com_banners
avatar SharkyKZ SharkyKZ - change - 11 Dec 2019
The description was changed
avatar SharkyKZ SharkyKZ - edited - 11 Dec 2019
8207024 11 Dec 2019 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 11 Dec 2019
Labels Added: ?
avatar jwaisner jwaisner - test_item - 5 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Jan 2020

I have tested this item successfully on 332c49f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27237.

avatar Quy Quy - test_item - 5 Jan 2020 - Tested successfully
avatar Quy
Quy - comment - 5 Jan 2020

I have tested this item successfully on 332c49f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27237.

avatar Quy Quy - change - 5 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27237.

avatar HLeithner HLeithner - change - 6 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-06 01:28:46
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 6 Jan 2020
avatar HLeithner HLeithner - merge - 6 Jan 2020
avatar HLeithner
HLeithner - comment - 6 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment