? Pending

User tests: Successful: Unsuccessful:

avatar vuchkov
vuchkov
7 Dec 2019

Pull Request for Issue #21452 .

Summary of Changes

Fix some some CodeSniffer (code-style) errors.

Testing Instructions

Expected result

Actual result

Documentation Changes Required

avatar vuchkov vuchkov - open - 7 Dec 2019
avatar vuchkov vuchkov - change - 7 Dec 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2019
Category Installation Libraries
avatar richard67
richard67 - comment - 8 Dec 2019

@vuchkov Shall this Pull Request (PR) here replace PR #21452 ? Or was this PR here meant to propose changes to PR #21452 ?

In the latter case you should make a PR not against the 4.0-dev branch of the CMS repo like this PR here is now, but make a PR against the branch of PR #21452 , which is https://github.com/bosunski/joomla-cms/tree/m1_copy. See the green frame in following screenshot about how to do that:

snap-1

avatar vuchkov
vuchkov - comment - 8 Dec 2019

@richard67 Yes, it is. Thank you.

I created the PR in the right way.

avatar richard67
richard67 - comment - 8 Dec 2019

@vuchkov Ok, I'll close this here for you.

avatar richard67
richard67 - comment - 8 Dec 2019

Closing in favour of bosunski#1, see the 2 comments before this one here.

avatar richard67 richard67 - change - 8 Dec 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-12-08 19:03:30
Closed_By richard67
Labels Added: ?
avatar richard67 richard67 - close - 8 Dec 2019

Add a Comment

Login with GitHub to post a comment