?
avatar Quy
Quy
3 Dec 2019

Maybe related to #26299.

JLIB_INSTALLER_ABORT_INSTALL_ABORTED is in \language\en-GB\lib_joomla.ini
Copying it to \administrator\language\en-GB\lib_joomla.ini fixes the translation, but is this the correct fix?

Steps to reproduce the issue

Install PatchTester.
Delete configuration.php
Reinstall.
Install PatchTester.

Actual result

JLIB_INSTALLER_ABORT_INSTALL_ABORTED

Additional comments

avatar Quy Quy - open - 3 Dec 2019
avatar joomla-cms-bot joomla-cms-bot - change - 3 Dec 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 3 Dec 2019
avatar infograf768
infograf768 - comment - 3 Dec 2019

Both lib_joomla.ini files should be exactly the same, so the string should also be added in admin for sure. At the same time would be good to compare these 2 files for other similar issues.

If the string can't be found in admin, it is fetched form frontend (this was done in the past to let TTs make "site-only packs").

The code is present in the loadLibraryLanguage() method in SiteApplication but not in CMSApplication. I suggest to also add the same conditional there but reversing the order of priorities (admin first).

avatar Quy
Quy - comment - 3 Dec 2019

Would you consider doing a PR for it since you have better understanding of it than I do? Thanks.

avatar infograf768
infograf768 - comment - 3 Dec 2019

Ok, will do asap.

avatar infograf768
infograf768 - comment - 3 Dec 2019

To test I may need to obtain the same error you got as I first want to modify CMSApplication.
What exactly did you try to install. I tried with both patchtester 4.0 and 3.0 and did not get any error.

avatar Quy
Quy - comment - 3 Dec 2019

Install PatchTester 3.0.
Delete configuration.php.
Reinstall Joomla.
Reinstall PatchTester 3.0.
Got the error/warning.

avatar infograf768
infograf768 - comment - 3 Dec 2019

Ok. Got the error.
In fact, it is just missing in backend. No need to load site one.
If a language has no admin lib_joomla.ini, it will use the en-GB one.
But both lib are not in sync and alpha order is not respected.
Making patch for that.

avatar infograf768 infograf768 - change - 3 Dec 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-12-03 10:36:45
Closed_By infograf768
avatar infograf768
infograf768 - comment - 3 Dec 2019

Please test
#27204

avatar infograf768 infograf768 - close - 3 Dec 2019

Add a Comment

Login with GitHub to post a comment