[#27194] - [4.0] Type-safe string comparisons in libraries
- Fixed in Code Base
- 8 Feb 2020
- Medium
- Build: 4.0-dev
- # 27194
- Diff
- SharkyKZ:j4/strict/string/libraries
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adds type-safe comparisons where appropriate.
Testing Instructions
Code review.
Documentation Changes Required
No.
| Labels |
Added:
?
|
||
I'm afraid - maybe tested it wrong?
Checked the files/lines of: ca295ab via FTP.
1st was succesful - 2nd & 3rd unsuccesful.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27194.
@ChristineWk This needs to be tested by code review only. If you're familiar with PHP code, review the changes here https://github.com/joomla/joomla-cms/pull/27194/files.
Thanks @SharkyKZ In the meantime, checked apprx. 20 files incld. given lines :-) successfully.
The last one: UserHelper.php & Uri.php: not successful. Maybe there was timed out? OK, will advise when I hv all :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27194.
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-02-08 16:15:07 |
| Closed_By | ⇒ | wilsonge |
Let me double check and will submit a PR if necessary.
Sorry. I forgot to respond to suggested change. I haven't looked at it properly so not sure if it's right. It seems to concern a form feld value, in which case I'd leave it as is. Just in case we might start storing those values as integers.
I have tested this item✅ successfully on ca295ab
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27194.