Labels |
Added:
?
|
@dgrammatiko its actually simpler than that.
The settings for cropperjs are in the media-action plugin and com_media uses the media-action plugin
However com_templates is simply loading the cropperjs files directly and not using the plugin :(
So presumably instead of doing that com_template should be doing
PluginHelper::importPlugin('media-action');
Someone better than me can dig in and resolve that. I've done the hard detective work
I had to dig in the history and what I found is that the functionality is the same as what exists in the J3.x. I did the ES6 renaming/changes and Charlie did the initial clean up of the file. The functionality was never questioned by either of us, I guess because we didn't encounter this case (?) https://github.com/joomla/joomla-cms/pull/15449/files#diff-3e83167bf7041bbf0b6294e5e132e9fdR106-R125
Anyways changing the initialisation options for the cropperjs should be sufficient to also cover this case
Anyways changing the initialisation options for the cropperjs should be sufficient to also cover this case
Are you able to do that please
Ok I’ll try to do a PR this weekend
Thank you
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-13 13:56:16 |
Closed_By | ⇒ | alikon |
Closed_Date | 2019-12-13 13:56:16 | ⇒ | 2019-12-13 13:56:17 |
Closed_By | alikon | ⇒ | joomla-cms-bot |
Set to "closed" on behalf of @alikon by The JTracker Application at issues.joomla.org/joomla-cms/27192
please test #27255
@brianteeman I don't think that we're doing anything different than the demo of the used script: https://fengyuanchen.github.io/cropperjs/
To patch this someone needs to dig into the options of that script and if the functionality is not available then restrict the area by some own code (I think we can interfere in the process)