Feeling Lucky
?
?
[#27189] - [4.0] Change plugin statistics popup to be alertdialog
- Fixed in Code Base
- 2 Dec 2019
- Medium
- Build: 4.0-dev
- # 27189
- Diff
- Quy:22507-alertdialog
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #22507 .
Summary of Changes
The plugin statistics popup should not have a role=alert as this role does not allow for a response by the user, instead it should have a role=alertdialog.
Testing Instructions
Enable System - Joomla! Statistics plugin.
View markup of the popup.
See role="alert".
Apply PR.
See role="alertdialog".
alikon
- comment
- 2 Dec 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189.
| Status | New | ⇒ | Ready to Commit |
alikon
- comment
- 2 Dec 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-02 16:20:11 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 2 Dec 2019
Thanks!
I have tested this item✅ successfully on 4f55581
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27189.