Feeling Lucky
?
?
[#27183] - [4.0] [plg_sampledata_multilang] Add missing checks
- Fixed in Code Base
- 3 Dec 2019
- Medium
- Build: 4.0-dev
- # 27183
- Diff
- SharkyKZ:j4/plg_sampledata_multilang
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Adds context check in last step. Fixes weird alert when installing Testing Sample Data.
Testing Instructions
- On monolingual site install Testing Sample Data. Inspect progress messages.
- On multilingual site install Multilingual Sample Data. Inspect progress messages.
Expected result
- Messages appear normally.
- Works like before.
Actual result
- Empty space appears between step 7 and step 8 messages.
Documentation Changes Required
No.
| Labels |
Added:
?
|
||
infograf768
- comment
- 1 Dec 2019
@SharkyKZ
If checking session is necessary for this plugin concerning the last Step, then it is also necessary for blog sample data as we only have there
public function onAjaxSampledataApplyStep4()
{
if ($this->app->input->get('type') != $this->_name)
{
return;
}
I suggest to also correct that one in this PR.
SharkyKZ
- comment
- 1 Dec 2019
Not really necessary in the last step.
infograf768
- comment
- 1 Dec 2019
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183.
| Status | New | ⇒ | Ready to Commit |
Quy
- comment
- 1 Dec 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183.
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-03 14:31:22 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
wilsonge
- comment
- 3 Dec 2019
Thanks!
I have tested this item✅ successfully on e3ebc69
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27183.