Success

User tests: Successful: Unsuccessful:

avatar CamJN
CamJN
23 Dec 2013

The parent constructor tries to use the connection that hasn't been established yet. I fixed that.

avatar CamJN CamJN - open - 23 Dec 2013
avatar Bakual
Bakual - comment - 4 Jun 2014

@CamJN Can you please check if that is still the case with current master?
Looking at the code I don't see where the parent constructor uses anything which uses the connection. In fact it looks the other way around in that getConnection needs $this->_hash to be set already, which is defined in the parent constructor.

I'm closing this PR since it's targeted against an old branch anyway. If yout think it's still an issue can you create a new PR against staging please? Thanks!

avatar Bakual Bakual - change - 4 Jun 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-06-04 19:19:52
avatar Bakual Bakual - close - 4 Jun 2014
avatar Bakual Bakual - close - 4 Jun 2014

Add a Comment

Login with GitHub to post a comment