? ? ? Pending

User tests: Successful: Unsuccessful:

avatar janschoenherr
janschoenherr
27 Nov 2019

Summary of Changes

Add Url fieldtype to Repeatable Field

Testing Instructions

Use the Url fieldtype in a repeatable field.

Documentation Changes Required

no.

avatar janschoenherr janschoenherr - open - 27 Nov 2019
avatar janschoenherr janschoenherr - change - 27 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2019
Category Administration Language & Strings Front End Plugins
avatar viocassel viocassel - test_item - 27 Nov 2019 - Tested successfully
avatar viocassel
viocassel - comment - 27 Nov 2019

I have tested this item successfully on 0b962a0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27167.

avatar Quy Quy - test_item - 29 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 29 Nov 2019

I have tested this item successfully on 0b962a0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27167.

avatar Quy Quy - change - 29 Nov 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27167.

avatar AndySDH
AndySDH - comment - 30 Nov 2019

Ehm in case you guys didn't notice, the goal is to deprecate Repeatable fields in Joomla 4, because the more robust Subfields have been implemented: see #24711
(which has support for EVERY field type, with all their params too).

It has already been merged, so it would be great if more people would test and improve that instead!

PS: Plus this PR doesn't really make sense by looking at the changes, this URL field is no different than the already present text field, there's no point, it's literally just the same option with a different language string

avatar janschoenherr
janschoenherr - comment - 3 Dec 2019

@AndySDH Subfields sounds like a nice feature. However, if it's only deprecated, it would still be nice to see this PR being merged.

The URL field renders an Input field of type url. It also provides context. When rendering the field, you know it is a link and can render it differently than a text field.

avatar rdeutz rdeutz - change - 3 Dec 2019
Labels Added: ? ?
avatar wilsonge
wilsonge - comment - 4 Dec 2019

I’m not so fussed about repeatable being deprecated going forward. I’m more concerned about the lack of validation (an ongoing issue in general with our repeatable fields support both in JForm and com_fields). Is there any relatively simple way we can add server side validation to this?

avatar SharkyKZ
SharkyKZ - comment - 5 Dec 2019

Subform field supports filtering and validation since 3.9.7.

avatar janschoenherr
janschoenherr - comment - 5 Dec 2019

@wilsonge Is there some form of validation with the current none repeatable url field? It seems only text filters are applied to it.

avatar HLeithner
HLeithner - comment - 5 Dec 2019

Sorry no new features in j3, we try to focus on j4.
It also seams nobody missed it the last 2 years. Now with the upcoming release of j4 this should be solved with subfields.

avatar HLeithner HLeithner - change - 5 Dec 2019
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2019-12-05 21:57:37
Closed_By HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 5 Dec 2019

Add a Comment

Login with GitHub to post a comment