? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
26 Nov 2019

Pull Request for Issue #26705.

Summary of Changes

When changing the article state, fix dropdown icon from disappearing.

Testing Instructions

  • Go to Articles.
  • Click on Published icon, then open the dropdown icon disappears.

Expected result

67145869-d4c7d300-f2a2-11e9-9b0e-2168ba23f5cd

Actual result

67145892-18224180-f2a3-11e9-8e60-f22ac79ff4bd

avatar Quy Quy - open - 26 Nov 2019
avatar Quy Quy - change - 26 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2019
Category Layout
avatar infograf768
infograf768 - comment - 28 Nov 2019

As far as I can see there is no difference here concerning the icon.
The icon always display before clicking on it, whatever the class change, and then disappears because the dropdown is displayed over it.
The wrong aspect of this PR is that it is creating a vertical scrollbar as paddings are lost.

avatar Quy
Quy - comment - 29 Nov 2019

See screenshots. They look the same. I don't see where paddings are lost.

27164-before

27164-after

avatar brianteeman
brianteeman - comment - 29 Nov 2019

@Quy the form.control class ??

avatar Quy
Quy - comment - 29 Nov 2019

These classes are overriden.

27164

avatar infograf768
infograf768 - comment - 29 Nov 2019

One can see the scrollbar issue when clicking on the arrow and the drodown displays

avatar Quy
Quy - comment - 29 Nov 2019

Sorry I must be blind as I don't see what you are seeing.

27164

avatar infograf768
infograf768 - comment - 1 Dec 2019

Firefox Macintosh

before your patch
dropdownbefore

After your patch
dropdown

Browser issue?

avatar Quy
Quy - comment - 6 Dec 2019

Notice in your Before screenshot that the dropdown with yellow highlight in the After screenshot is also in the Before screenshot before the grey drop down displays over it. It could be a browser issue. Do you have another browser to test?

avatar infograf768
infograf768 - comment - 6 Dec 2019

Got same behavior on Chrome and Safari here on Macintosh except no scrollbar after your patch.
Screen Shot 2019-12-06 at 07 54 18

avatar Quy
Quy - comment - 26 Jan 2020

It is correct to have no scroll bar. Do you get the yellow highlight in other drop downs like the language dropdown on the first installation page?

avatar Quy
Quy - comment - 12 Mar 2020

@infograf768 Can you please test again to see if it ok now with the new template? Does it behave the same as the other dropdowns on this page?

avatar infograf768
infograf768 - comment - 12 Mar 2020

will test tomorrow

avatar N6REJ
N6REJ - comment - 12 Mar 2020

I don't even see the issue using this morning's pull

image

avatar Quy
Quy - comment - 12 Mar 2020

You should see the blue background.

27164

avatar richard67
richard67 - comment - 12 Mar 2020

I can reproduce the issue and confirm the PR solves it.

@infograf768 I don't have the scrollbar issue, neither with LTR nor with RTL.

avatar richard67
richard67 - comment - 12 Mar 2020

I have tested this item successfully on 5691021

I can reproduce the issue, PR solves it for me with both LTR and RTL. If it's right or wrong I can't judge.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

avatar richard67 richard67 - test_item - 12 Mar 2020 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Mar 2020

issue replicated and patch resolves


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

avatar brianteeman
brianteeman - comment - 12 Mar 2020

I have tested this item successfully on 5691021


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

avatar brianteeman brianteeman - test_item - 12 Mar 2020 - Tested successfully
avatar richard67 richard67 - change - 12 Mar 2020
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 12 Mar 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27164.

avatar richard67 richard67 - change - 12 Mar 2020
Labels Added: ? ?
avatar infograf768
infograf768 - comment - 13 Mar 2020

Sorry to say, but on Macintosh clean install I still have the wrong behavior...
here with Firefox, after patch.
arrow

avatar richard67
richard67 - comment - 13 Mar 2020

@inograf768 I used latest version of Firefox, but on Windows. So what shall we do now? Remove RTC?

avatar brianteeman
brianteeman - comment - 13 Mar 2020

That is a native browser display you are seeing. Nothing can be done about that.

avatar infograf768
infograf768 - comment - 13 Mar 2020

I have a similar behavior for safari and chrome on Macintosh as I stated before.

avatar infograf768
infograf768 - comment - 13 Mar 2020

It may be of interest to see the behavior for other fields:

arrow2

As one can see, the arrow and dropdown works perfectly for ordering and limit

avatar Quy
Quy - comment - 13 Mar 2020

You have the same issue with - Select Condition - which has nothing to do with this PR.

avatar infograf768
infograf768 - comment - 13 Mar 2020

You have the same issue with - Select Condition - which has nothing to do with this PR.

Indeed. Do you keep the arrow for this field on your settings?

avatar Quy
Quy - comment - 13 Mar 2020

It displays fine on Windows. I will have to test on Mac later today and see if anything can be done unless you want to give it a shot first.

avatar infograf768
infograf768 - comment - 13 Mar 2020
avatar Quy
Quy - comment - 13 Mar 2020

Can you give it a try in a separate PR as I have to ask a friend to get access to a Mac?

avatar Quy
Quy - comment - 13 Mar 2020

@wilsonge Please merge. The issue mentioned by JM is a separate issue and OSX specific. Thanks.

avatar wilsonge wilsonge - close - 13 Mar 2020
avatar wilsonge wilsonge - merge - 13 Mar 2020
avatar wilsonge wilsonge - change - 13 Mar 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-03-13 15:42:16
Closed_By wilsonge
Labels
avatar wilsonge
wilsonge - comment - 13 Mar 2020

But I use a macbook too :P clearly a high priority issue :P

Thankyou!

Add a Comment

Login with GitHub to post a comment