User tests: Successful: Unsuccessful:
Pull Request for Issue #27135 .
Moves sidebar icons to using flex. Fixes alignment issue.
Apply this patch and run node build.js --compile-css for updating the changed SCSS.
Check sidebar icons are aligned.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Labels |
Added:
?
|
FYI, code for rtl is in template-rtl.scss
Looks like the issue is partly
.main-nav .has-arrow .sidebar-item-title {
margin-right: auto;
}
which should be
margin-left: auto;
in RTL
but this not sufficient to solve the position of the arrows
Thank you. Badges fixed.
I have tested this item
Will test later. Maybe worth adding all rtl specific overrides in the sidebar.scss as I did already for other rtl stuff in various PRs in the recent weeks.
I propose this patch which includes your changes but moves to _sidebar.scss all main-nav rtl stuff (improved) and deletes it from template-rtl.scss.
If you agree, could you update your PR?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-27 09:51:05 |
Closed_By | ⇒ | ciar4n |
Status | Closed | ⇒ | New |
Closed_Date | 2019-11-27 09:51:05 | ⇒ | |
Closed_By | ciar4n | ⇒ |
Status | New | ⇒ | Pending |
I have moved the rtl to the sidebar.scss as suggested. Also removed some redundant css.
@ciar4n
Your patch is working but I wonder about
a {
[dir=ltr] & {
padding-left: 3rem;
}
[dir=rtl] & {
padding-right: 3rem;
}
and similar further
a::before {
[dir=ltr] & {
left: 1.25rem;
}
[dir=rtl] & {
right: 1.25rem;
}
}
Do we need the [dir=ltr]
or is it there to just prevent adding a padding-right: 0
in the rtl part?
Do we need the [dir=ltr] or is it there to just prevent adding a padding-right: 0 in the rtl part?
Yes exactly. It avoids having to correct the ltr css in the rtl.
Personally I find defining both ltr and rtl a little cleaner and easier to read. It also makes me more rtl aware (which I tend to forget about).
Alas I am happy to change it to whichever you prefer?
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
I like the idea. Cleaner indeed. Rtc.
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-27 16:10:09 |
Closed_By | ⇒ | infograf768 | |
Labels |
Added:
?
|
Tks!
Thank you for the tests
This totally breaks RTL...
