? ? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
26 Nov 2019

Pull Request for Issue #27135 .

Summary of Changes

Moves sidebar icons to using flex. Fixes alignment issue.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS.

Check sidebar icons are aligned.

Before PR

image

With PR

image

Documentation Changes Required

95c3763 24 Nov 2019 avatar ciar4n init
avatar ciar4n ciar4n - open - 26 Nov 2019
avatar ciar4n ciar4n - change - 26 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2019
Category Administration Templates (admin)
avatar ciar4n ciar4n - change - 26 Nov 2019
Labels Added: ?
avatar infograf768
infograf768 - comment - 26 Nov 2019

This totally breaks RTL...
Screen Shot 2019-11-26 at 11 02 05

avatar infograf768
infograf768 - comment - 26 Nov 2019

FYI, code for rtl is in template-rtl.scss

avatar infograf768
infograf768 - comment - 26 Nov 2019

Looks like the issue is partly
.main-nav .has-arrow .sidebar-item-title {
margin-right: auto;
}

which should be
margin-left: auto;
in RTL
but this not sufficient to solve the position of the arrows

avatar ciar4n
ciar4n - comment - 26 Nov 2019

Should be ok now...

image

avatar infograf768
infograf768 - comment - 26 Nov 2019

RTL solved.

Another issue with the home multilingual menutypes

before:
Screen Shot 2019-11-26 at 11 54 53

after
Screen Shot 2019-11-26 at 11 56 50

the badges are added in
mod_menu/tmp/default_submenu.php line 113
and
mod_submenu/Menu/Menu.php line 176

avatar ciar4n
ciar4n - comment - 26 Nov 2019

Thank you. Badges fixed.

avatar Quy Quy - test_item - 26 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Nov 2019

I have tested this item successfully on 697f52f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27156.

avatar infograf768
infograf768 - comment - 26 Nov 2019

Will test later. Maybe worth adding all rtl specific overrides in the sidebar.scss as I did already for other rtl stuff in various PRs in the recent weeks.

avatar infograf768
infograf768 - comment - 27 Nov 2019

@ciar4n

I propose this patch which includes your changes but moves to _sidebar.scss all main-nav rtl stuff (improved) and deletes it from template-rtl.scss.
If you agree, could you update your PR?

navbar_rtl.diff.zip

avatar ciar4n ciar4n - change - 27 Nov 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-11-27 09:51:05
Closed_By ciar4n
avatar ciar4n ciar4n - close - 27 Nov 2019
avatar ciar4n ciar4n - change - 27 Nov 2019
Status Closed New
Closed_Date 2019-11-27 09:51:05
Closed_By ciar4n
avatar ciar4n ciar4n - change - 27 Nov 2019
Status New Pending
avatar ciar4n ciar4n - reopen - 27 Nov 2019
avatar infograf768
infograf768 - comment - 27 Nov 2019

@ciar4n
I modified the .zip above to indent correctly the arrow in submenu

+[dir=rtl] .main-nav ul .dropdown-submenu a {
+  padding: 0 2.0rem 0 1rem;

Test can be done using the alternate preset.

avatar ciar4n
ciar4n - comment - 27 Nov 2019

@infograf768

I have moved the rtl to the sidebar.scss as suggested. Also removed some redundant css.

avatar infograf768
infograf768 - comment - 27 Nov 2019

@ciar4n
Your patch is working but I wonder about

      a {
        [dir=ltr] & {
          padding-left: 3rem;
        }

        [dir=rtl] & {
          padding-right: 3rem;
        }

and similar further

      a::before {
        [dir=ltr] & {
          left: 1.25rem;
        }

        [dir=rtl] & {
          right: 1.25rem;
        }
      }

Do we need the [dir=ltr] or is it there to just prevent adding a padding-right: 0 in the rtl part?

avatar ciar4n
ciar4n - comment - 27 Nov 2019

Do we need the [dir=ltr] or is it there to just prevent adding a padding-right: 0 in the rtl part?

Yes exactly. It avoids having to correct the ltr css in the rtl.

Personally I find defining both ltr and rtl a little cleaner and easier to read. It also makes me more rtl aware (which I tend to forget about).

Alas I am happy to change it to whichever you prefer?

avatar infograf768 infograf768 - test_item - 27 Nov 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 27 Nov 2019

I have tested this item successfully on 9166828


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27156.

avatar infograf768 infograf768 - change - 27 Nov 2019
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 27 Nov 2019

I like the idea. Cleaner indeed. Rtc.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27156.

avatar infograf768 infograf768 - change - 27 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-27 16:10:09
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 27 Nov 2019
avatar infograf768 infograf768 - merge - 27 Nov 2019
avatar infograf768
infograf768 - comment - 27 Nov 2019

Tks!

avatar ciar4n
ciar4n - comment - 27 Nov 2019

Thank you for the tests

Add a Comment

Login with GitHub to post a comment