? Pending

User tests: Successful: Unsuccessful:

avatar ciar4n
ciar4n
26 Nov 2019

Pull Request for Issue #27136.

Summary of Changes

This PR applies #27141 to the remaining forms.

Testing Instructions

Apply this patch and run node build.js --compile-css for updating the changed SCSS.

Ensure options column layout is correct. The majority of this PR effects the Global Configuration form layout. For details on these changes, take look at #27141.

avatar ciar4n ciar4n - open - 26 Nov 2019
avatar ciar4n ciar4n - change - 26 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2019
Category Administration com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_joomlaupdate
avatar Quy
Quy - comment - 26 Nov 2019

Fieldset/legend not styled.

BEFORE:
27153-before

AFTER:
27153-after

avatar ciar4n
ciar4n - comment - 26 Nov 2019

Fieldset/legend not styled.

@Quy I am unable to replicate this. Full refresh after compiling?

avatar Quy
Quy - comment - 26 Nov 2019

Installed your branch and it is fine. Yes, full refresh after compiling. I must have done something wrong. Thanks.

avatar Quy
Quy - comment - 26 Nov 2019

Will the following be one column? I see that this is the case with Configure Edit Screen.

27153-options

avatar ciar4n
ciar4n - comment - 26 Nov 2019

My personal preference would be all one column but it was not my intent here to change that. It looks like I missed the Configure Edit Screen tab.

avatar ciar4n ciar4n - change - 26 Nov 2019
Labels Added: ?
avatar ciar4n
ciar4n - comment - 26 Nov 2019

I have moved the Configure Edit Screen to 3 columns as before.

avatar Quy
Quy - comment - 26 Nov 2019

That would be my preference too as I find it disorienting in columns as mentioned in ##25891.

avatar Quy
Quy - comment - 26 Nov 2019

Table not full width under Global Configuration > Permissions.

27153-permissions

avatar brianteeman
brianteeman - comment - 26 Nov 2019

that one is a special case iirc and has a class specified administrator\components\com_config\tmpl\application\default_permissions.php

avatar ciar4n
ciar4n - comment - 27 Nov 2019

Thank you. It should be ok now.

avatar Quy
Quy - comment - 27 Nov 2019

Debug Language moves depending on the selection. Is this beyond the scope of this PR?
When Yes, it is in the first column.
When No, it is in the second column.

debug-on

debug-off

PS: Global Configuration differs from the other Components' settings by having 2 columns vs 1 column.

avatar ciar4n
ciar4n - comment - 28 Nov 2019

Thanks @Quy. I'll have a look in to this in the morning.

avatar ciar4n
ciar4n - comment - 28 Nov 2019

Debug Language moves depending on the selection.

Debug fields re-ordered to amend this issue..

c51JcHZx4X

avatar Quy Quy - test_item - 29 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 29 Nov 2019

Sorry another one with Connection Encryption:

27153-database-1way

27153-database-2way

avatar ciar4n
ciar4n - comment - 16 Dec 2019

Sry @Quy.. I'd forgotten about this.

Currently no way around stopping the jump here. The column-count CSS property, by default, evenly splits content across the set number of columns.. Because this show-on adds so many new fields, some of the fields will always jump to the first column.

AFAIK we can not set the break point (spec.. https://drafts.csswg.org/css-multicol-1/#cc). Even if we can, I suspect #27165 will be an issue

avatar jwaisner jwaisner - test_item - 11 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 11 Jan 2020

I have tested this item successfully on 11a3af8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27153.

avatar jwaisner jwaisner - test_item - 12 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 12 Jan 2020

I have tested this item successfully on 1e661b6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27153.

avatar infograf768
infograf768 - comment - 13 Jan 2020

It does no solve #27490

avatar wilsonge wilsonge - change - 18 Jan 2020
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-18 12:23:30
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Jan 2020
avatar wilsonge wilsonge - merge - 18 Jan 2020
avatar wilsonge
wilsonge - comment - 18 Jan 2020

Thanks!

avatar wilsonge
wilsonge - comment - 18 Jan 2020

Sorry for missing this when it first came in

Add a Comment

Login with GitHub to post a comment