? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
24 Nov 2019

Summary of Changes

Remove duplicate class when monochrome template setting and accessibility setting are enabled.

Testing Instructions

Code review

Expected result

<body class="admin com_templates view-style layout-edit task-display monochrome">

Actual result

<body class="admin com_templates view-style layout-edit task-display monochrome monochrome">

avatar Quy Quy - open - 24 Nov 2019
avatar Quy Quy - change - 24 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Nov 2019
Category Administration Templates (admin)
avatar Quy Quy - change - 24 Nov 2019
The description was changed
avatar Quy Quy - edited - 24 Nov 2019
avatar Quy Quy - change - 24 Nov 2019
The description was changed
avatar Quy Quy - edited - 24 Nov 2019
avatar brianteeman brianteeman - test_item - 24 Nov 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 24 Nov 2019

I have tested this item successfully on 8957a86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27145.

avatar brianteeman
brianteeman - comment - 24 Nov 2019

Can you update the title please to something more meaningful as it will be the commit message

avatar Quy Quy - change - 24 Nov 2019
Title
[4.0] Simplify code
[4.0] Remove duplicate class for monochrome settings
avatar Quy Quy - edited - 24 Nov 2019
avatar SharkyKZ SharkyKZ - test_item - 25 Nov 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 25 Nov 2019

I have tested this item successfully on 8957a86


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27145.

avatar SharkyKZ SharkyKZ - change - 25 Nov 2019
Status Pending Ready to Commit
Labels Added: ?
avatar SharkyKZ
SharkyKZ - comment - 25 Nov 2019

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27145.

avatar wilsonge wilsonge - change - 25 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-25 11:06:51
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 25 Nov 2019

Thanks!

Add a Comment

Login with GitHub to post a comment