? Success

User tests: Successful: Unsuccessful:

avatar teja-amil teja-amil - open - 22 Dec 2013
avatar radiant-tech
radiant-tech - comment - 22 Feb 2014

@teja-amil - the param 'show_category_heading_title' in intended to show/hide the category title, not the "Subcategories" text.

I believe instead, the "if" statement should be revised to also check whether we want to hide empty child categories.

As it stands now, you can hide the Subcategories text only if you set "Subcategory Levels" (maxLevel) to None. You should be able to leave levels to something other than None while still having it obey "Empty Categories" set to hide (not necessary to show "Subcategories" text if all the children are empty).

Hope that makes sense. If you update the PR, I'll provide a test. :)

avatar teja-amil
teja-amil - comment - 22 Feb 2014

@radiant-tech Thanks for the heads-up! Updated the PR. Please go ahead and fix this.

avatar radiant-tech
radiant-tech - comment - 24 Feb 2014

@teja-amil - Sorry, but the fix I provided was not correct, since it's only looking at the "empty cats" param setting instead of whether we have at least one subcat with an item to show. I've proposed a better solution at #3175 -- please feel free to test and report back there or in it's related Tracker.

While waiting for the fix to be accepted, you could avoid a core hack and override the layout content category file in your template. Where I am using $displayData->get('category')->childrennumitems, you would need to use ($displayData->get('category')->getNumItems(true) - $displayData->get('category')->getNumItems(false)) > 0

avatar Bakual
Bakual - comment - 2 Mar 2014

I've proposed a better solution at #3175

Can this one be closed then?

avatar radiant-tech
radiant-tech - comment - 2 Mar 2014

Yes, I would recommend closing this one.

avatar Bakual
Bakual - comment - 2 Mar 2014

Closing as requested.

avatar Bakual Bakual - change - 2 Mar 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-03-02 14:28:06
avatar Bakual Bakual - close - 2 Mar 2014

Add a Comment

Login with GitHub to post a comment