? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
23 Nov 2019

Summary of Changes

Adding specific css for mobile view

Testing Instructions

Install a multilingual site.
Edit an associated item. Display the Associations tab.
Reduce window size to mobile view

patch and run npm

Before patch

The title of the associated item is cut

fieldset-assoc_before

After patch

fieldset-assoc

avatar infograf768 infograf768 - open - 23 Nov 2019
avatar infograf768 infograf768 - change - 23 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Nov 2019
Category Administration Templates (admin)
avatar infograf768 infograf768 - change - 23 Nov 2019
The description was changed
avatar infograf768 infograf768 - edited - 23 Nov 2019
avatar richard67 richard67 - test_item - 23 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 23 Nov 2019

I have tested this item successfully on 3da2eff


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27128.

avatar ciar4n
ciar4n - comment - 23 Nov 2019

Presuming a field with 3 appended buttons can potentially be found anywhere, should this fix be applied globally instead of just within associations?

avatar infograf768
infograf768 - comment - 23 Nov 2019

Presuming a field with 3 appended buttons can potentially be found anywhere, should this fix be applied globally instead of just within associations?

Good question. I have not found any other occurence in core.
PR can be modified easily if desired.

avatar ciar4n
ciar4n - comment - 24 Nov 2019

Considering the XML allows multiple buttons, I think the field CSS should support them globally regardless if used elsewhere. within core

Rather than using a media query, as this is a flex object simply apply a min-width to the input. The buttons should wrap once the input field hits that width.

avatar infograf768
infograf768 - comment - 24 Nov 2019

Rather than using a media query, as this is a flex object simply apply a min-width to the input. The buttons should wrap once the input field hits that width.

Please suggest patch. Flex is somehow a foreign concept to me. ;)

avatar ciar4n
ciar4n - comment - 24 Nov 2019

Adding something like this instead should work...

(edit to taste)

.input-group input {
    min-width: 200px;
}
avatar ciar4n
ciar4n - comment - 24 Nov 2019

... buttons will wrap once the input is less than 200px

avatar infograf768 infograf768 - change - 24 Nov 2019
Labels Added: NPM Resource Changed ?
avatar infograf768
infograf768 - comment - 24 Nov 2019

@ciar4n
Done. Used 220px to normalize.
@richard67 Please test again

avatar infograf768 infograf768 - change - 25 Nov 2019
Labels Removed: NPM Resource Changed
avatar Quy Quy - test_item - 25 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 25 Nov 2019

I have tested this item successfully on 06471a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27128.

avatar richard67 richard67 - test_item - 25 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 25 Nov 2019

I have tested this item successfully on 06471a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27128.

avatar richard67 richard67 - change - 25 Nov 2019
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 25 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27128.

avatar infograf768 infograf768 - change - 26 Nov 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 27 Nov 2019
Labels Added: NPM Resource Changed
avatar wilsonge
wilsonge - comment - 27 Nov 2019

I think in menus we might have a use of this where you can create articles in the modal. select/create/clear or something

avatar wilsonge wilsonge - change - 27 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-27 20:57:25
Closed_By wilsonge
Labels Removed: NPM Resource Changed
avatar wilsonge wilsonge - close - 27 Nov 2019
avatar wilsonge wilsonge - merge - 27 Nov 2019
avatar wilsonge
wilsonge - comment - 27 Nov 2019

Thanks @ciar4n and @infograf768 !

avatar infograf768
infograf768 - comment - 28 Nov 2019

Mostly @ciar4n !

Add a Comment

Login with GitHub to post a comment