? ? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
20 Nov 2019

Pull Request for Issue # .

Summary of Changes

Adds parameterized queries in Joomla\CMS\Helper\TagsHelper.

Testing Instructions

Test that adding and remove tags from content items work.
Test that creating tags on the fly and searching tags work.
Test that com_tags frontend views like before.

Expected result

Works like before.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 20 Nov 2019
avatar SharkyKZ SharkyKZ - change - 20 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Nov 2019
Category Libraries
47f9d2e 20 Nov 2019 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 20 Nov 2019
Labels Added: ?
avatar Quy
Quy - comment - 20 Nov 2019

Edit an article.
Type an existing tag in the Tags field.
No results match.

Undefined variable: filter in \libraries\src\Helper\TagsHelper.php on line 900

7d33b23 20 Nov 2019 avatar SharkyKZ Typo
avatar SharkyKZ
SharkyKZ - comment - 20 Nov 2019

@Quy Fixed.

avatar Quy
Quy - comment - 20 Nov 2019

When creating a new tag while editing an article:

Save failed with the following error: Incorrect datetime value: 'CURRENT_TIMESTAMP()' for column joomla_db.rkl56_contentitem_tag_map.tag_date at row 1

avatar SharkyKZ
SharkyKZ - comment - 20 Nov 2019

Should be fixed now.

avatar Quy
Quy - comment - 21 Nov 2019

PHP Warning: array_merge(): Expected parameter 3 to be an array, string given in \libraries\src\Helper\TagsHelper.php on line 109

PHP Warning: implode(): Invalid arguments passed in \libraries\src\Helper\TagsHelper.php on line 109

avatar Quy Quy - test_item - 26 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 26 Nov 2019

I have tested this item successfully on 8b1d50b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27107.

avatar jwaisner jwaisner - test_item - 5 Jan 2020 - Tested successfully
avatar jwaisner
jwaisner - comment - 5 Jan 2020

I have tested this item successfully on 8b1d50b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27107.

avatar Quy Quy - change - 5 Jan 2020
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Jan 2020

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27107.

avatar HLeithner HLeithner - close - 6 Jan 2020
avatar HLeithner HLeithner - merge - 6 Jan 2020
avatar HLeithner HLeithner - change - 6 Jan 2020
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2020-01-06 01:28:03
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 6 Jan 2020

Thanks

Add a Comment

Login with GitHub to post a comment