[#27074] - [4.0] Correcting mod_submenu markup
- Fixed in Code Base
- 20 Nov 2019
- Medium
- Build: 4.0-dev
- # 27074
- Diff
- infograf768:4.0_modsubmenu_markup
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #27068
Summary of Changes
Separating title and iconImage
Adding possible translation in order to normalise code. Which does not mean the translation of possible menutype titles fully work. To work really a lot of other stuff is to be considered.
Testing Instructions
See #27068
Source after patch
<li class="list-group-item d-flex align-items-center">
<a class="flex-grow-1" href="index.php?option=com_menus&view=items&menutype=mainmenu-en-gb">
Main Menu (en-GB) <span class="badge badge-secondary">en-GB</span></a>
<span class="menu-quicktask">
<a href="index.php?option=com_menus&task=item.add&menutype=mainmenu-en-gb">
<span class="fa fa-plus fa-xs" title="Main Menu (en-GB) " aria-hidden="true"></span>
<span class="sr-only">Main Menu (en-GB) - New Item</span>
</a>
</span>
</li>
<li class="list-group-item d-flex align-items-center">
<a class="flex-grow-1" href="index.php?option=com_menus&view=items&menutype=mainmenu">
Main Menu <span class="home-image icon-featured" aria-hidden="true"></span><span class="sr-only">Default</span></a>
<span class="menu-quicktask">
<a href="index.php?option=com_menus&task=item.add&menutype=mainmenu">
<span class="fa fa-plus fa-xs" title="Main Menu " aria-hidden="true"></span>
<span class="sr-only">Main Menu - New Item</span>
</a>
</span>
</li>
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Administration |
I have tested this item
Don't know if maybe relevant, therefore just FYI (OT): If someone decide during Patch test, additional red markups, these belongs to #27061 and is solved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.
I followed the instructions but I was not able to reproduce the issue
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.
Do not rtc for now.
| Labels |
Added:
?
|
||
Note: we will have to do the same change in conditional for mod_menu/tmp/default_submenu.php, including htmlspecialchars for Text::_($current->title)
Will you do this in a separate PR?
Will you do this in a separate PR?
Yes. Better separate as the other one is mainly moving code around.
Let’s get this one in first.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.
@chmst @ChristineWk
Please test again
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-20 09:10:50 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on ae28d83
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27074.