Feeling Lucky
?
[#2706] - $app->registeredurlparams is not defined
- Closed
- 2 Mar 2014
- Medium
- Build: staging
- # 2706
- Diff
- FriendlyHacker:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Moving the rest of the function inside the if loop makes sure $app->registeredurlparams is only referred to if actually exists.
This was causing memory leak on 3.2.1 Joomla install over PHP 5.5, performance has increased after the fix.
FriendlyHacker
- comment
- 30 Dec 2013
Yes, if my patch breaks anything it makes more sense to just define it again. Will add it to issue tracker and get back to you with a link.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-03-02 14:01:38 |
Wouldn't it make sense to just define
$registeredurlparams = new stdClassif not present?Your patch would change the behavior in that it only returns
$safeuriaddonif some safe url params are registered, while currently it always will return at least the default values.Thus imho this may break something if the extensions only needs the default params.
Or am I missing something?
Also can you please add a tracker item on JoomlaCode (http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103). We still use that one to track our issues. Thanks