?
avatar brianteeman
brianteeman
12 Nov 2019

Am I correct that in Joomla 4 it is not possible to configure a site as a multilingual site during the install OR to set the language that should be used as the default admin language or the default site language?

I can see that the default language stuff has been removed from the code but the language strings are still present

I can see the code to configure a multilingual site in the languagecontroller.php but its not presented to the user at all

If this is all as intended then I can go ahead and remove the unused code and strings

avatar brianteeman brianteeman - open - 12 Nov 2019
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2019
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - labeled - 12 Nov 2019
avatar infograf768
infograf768 - comment - 12 Nov 2019

Multilingual installation is indeed no more possible at J install time. The code is now in the plugin.
But imho we should still improve installation by being able to choose admin and site default language after installing languages.
This as well as the session lang issue are to be done before beta.

avatar brianteeman
brianteeman - comment - 12 Nov 2019

Multilingual installation is indeed no more possible at J install time. The code is now in the plugin.

The plugin is called Multilungual Sample Data in a group called sample data. It is not intuitive that this will setup your web site easily for a multilingual web site. Perhaps it should be renamed

If it is definitely not going to be in the installer then all the code/strings for it should be removed.

But imho we should still improve installation by being able to choose admin and site default language after installing languages.

Then there should at least be an issue tracker for it so that someone might possibly write the code

This as well as the session lang issue are to be done before beta.

Sorry, no idea what this is

@wilsonge please advise on progressing here. Getting the install workable is far more important than modifying existing code a thousand times just to keep on trend

avatar infograf768
infograf768 - comment - 12 Nov 2019

The plugin is called Multilungual Sample Data in a group called sample data. It is not intuitive that this will setup your web site easily for a multilingual web site.

One could say the same about blog sample data. I don’t see that changing its name would change the situation. I am not the one who took the decision to use these plugins instead of what we had before in 3.x.

In any case one can indeed take away the related methods from the helper. They are the same as those in the plugin.

We already have an old issue for the lang session issue and @wilsonge is aware of that.
To test select en-US at install time. Go on installing until you get to install languages. Look at language in source at each stage. en-GB gets loaded instead of en-US.

Concerning default site and admin lang, I will create the issue. Alas the installation code was quite abandoned for many months and its code is extremely complex.

avatar wilsonge
wilsonge - comment - 15 Nov 2019

We already have an old issue for the lang session issue and @wilsonge is aware of that.

I'm aware but not sure I've seen a GitHub issue for it? It's certainly not tagged with release blocker like it should be. It's only reset after the Joomla install is done and we swap the session over to use database driven sessions rather than the file driven one iirc

But imho we should still improve installation by being able to choose admin and site default language after installing languages.

I'd agree with this. You shouldn't have to log in in a foreign language (i.e. english). But sample data should be kept in admin only - not as part of the installer

avatar infograf768
infograf768 - comment - 15 Nov 2019

looks l have to create 2 new issues then ?

avatar infograf768
infograf768 - comment - 16 Nov 2019
avatar wilsonge wilsonge - change - 18 Nov 2019
Labels Added: ?
avatar wilsonge wilsonge - labeled - 18 Nov 2019
avatar wilsonge
wilsonge - comment - 18 Nov 2019

And i've added a release blocker here and we'll use this issue to track being able to set the default site/admin languages in the installer

avatar infograf768
infograf768 - comment - 19 Nov 2019

Choosing default lang issue is here:
#27087

avatar brianteeman
brianteeman - comment - 1 Jan 2020

Looking into this and I see that the ability to set the default language has never been part of the installer in J4 - oops

avatar HLeithner
HLeithner - comment - 2 Jan 2020

@infograf768 can you look into this and port it from j3?

avatar infograf768
infograf768 - comment - 2 Jan 2020

@HLeithner
I am afraid j installation for j4 is so different from j3 that I do not have the knowledge to help on this. What I know is that the methods still exist in the model, that’s about all. Same for the session issue.

avatar HLeithner
HLeithner - comment - 2 Jan 2020

ok thanks, hope someone can have a look at it soon.

avatar brianteeman
brianteeman - comment - 8 Jan 2020

I am working on this - hope to have a draft later tody

avatar brianteeman
brianteeman - comment - 14 Jan 2020

Sorry not made much progress on this

avatar infograf768
infograf768 - comment - 15 Jan 2020

3 files are concerned:
installation/src/View/Remove/HtmlView.php
installation/template/js/remove.js
installation/tmpl/remove/default.php

I could here manage to display a specific defaultLanguages fieldset

Screen Shot 2020-01-03 at 10 48 04

But remains 3 aspects to solve, so it is totally WIP.

  1. getting to the default Languages fieldset after installing languages (it works when I skip directly instead of installing languages)
  2. getting that fieldset form task to be submitted (needs some specific code in remove.js, what I have done is not working and I know it )
  3. I also have a weird error in the htmlview.php if I follow the way the variables are coded there although it works.

If you like, I can post here my unfinished .diff

avatar brianteeman
brianteeman - comment - 15 Jan 2020

If you could that would be great and then I can try and get i done while on holiday in spain

avatar infograf768
infograf768 - comment - 15 Jan 2020
avatar wilsonge
wilsonge - comment - 16 Feb 2020

@brianteeman @infograf768 is this #27951 WIP with notes on what's left to do enough for one of you guys to pick up and finish?

avatar brianteeman
brianteeman - comment - 16 Feb 2020

Its on my todo list for tomorrow

avatar brianteeman
brianteeman - comment - 16 Feb 2020

not really very motivated to work on it - when it will sit there ofr months without tests or comments other than you have an extra space and please fix merge conflicts again - which seems to be the norm for anything that isnt trivial

avatar richard67
richard67 - comment - 16 Feb 2020

@brianteeman Ping me when you have something which can be tested and I'll promise I'll test and advertise to others. It only can be that I am limited to weekends regarding time and personal power.

avatar brianteeman
brianteeman - comment - 16 Feb 2020

nearly done

avatar richard67
richard67 - comment - 15 Mar 2020

@brianteeman Can this be closed now as we have PR #28328 ? Or is there something left to be done?

avatar infograf768 infograf768 - change - 15 Mar 2020
Status New Closed
Closed_Date 0000-00-00 00:00:00 2020-03-15 09:10:54
Closed_By infograf768
avatar infograf768
infograf768 - comment - 15 Mar 2020

We can safely close this.

avatar infograf768 infograf768 - close - 15 Mar 2020
avatar brianteeman
brianteeman - comment - 15 Mar 2020

nice to have more than 3 minutes to answer the question

avatar richard67
richard67 - comment - 15 Mar 2020

Well to me it reads as if it is solved by that PR, but I always prefer to ask an issue's author because it always can be I have missed something when reading. That's why I had asked. Please protest if closing was wrong.

avatar wilsonge wilsonge - change - 18 Dec 2020
Labels Removed: ?
avatar wilsonge wilsonge - unlabeled - 18 Dec 2020

Add a Comment

Login with GitHub to post a comment