? Pending

User tests: Successful: Unsuccessful:

avatar N6REJ
N6REJ
12 Nov 2019

updates list field type to use use Joomla\CMS\Language\Text; instead of JText

Pull Request for Issue # .

Summary of Changes

changed JText to Text

Testing Instructions

  1. create list field type.
  2. make sure its still visible and works.

Expected result

Works as expected

Actual result

Documentation Changes Required

None

@wilsonge @SharkyKZ Peer review?

avatar N6REJ N6REJ - open - 12 Nov 2019
avatar N6REJ N6REJ - change - 12 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2019
Category Front End Plugins
avatar brianteeman
brianteeman - comment - 12 Nov 2019

Unless you plan on namespacing all of joomla 3 I don't see the need for this change

avatar SharkyKZ
SharkyKZ - comment - 12 Nov 2019

This has already been done in 4.0.

avatar N6REJ
N6REJ - comment - 12 Nov 2019

I know its been done in 4 but figured since some parts of 3.9 had it and I spotted it might as well.. can't hurt.

avatar brianteeman
brianteeman - comment - 12 Nov 2019

Unless you are going to do it everywhere then I wouldnt as it introduces a level of inconsistency that has no benefit

avatar N6REJ
N6REJ - comment - 13 Nov 2019

I'd be willing to do it to all the form fields if it's helpful

avatar SharkyKZ
SharkyKZ - comment - 13 Nov 2019

Doing this against staging is not helpful for the reasons stated above. But doing this in 4.0 would be helpful. There are still many instances of this in 4.0.

avatar N6REJ N6REJ - change - 15 Nov 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-11-15 21:31:19
Closed_By N6REJ
Labels Added: ?
avatar N6REJ N6REJ - close - 15 Nov 2019

Add a Comment

Login with GitHub to post a comment