? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
11 Nov 2019

Summary of Changes

Quickstarts are added for Site Modules, Administrator modules and Custom Administrator Menus when using the alternative preset.

Quickstarts are added for Administrator modules and Custom Administrator Menus when using the default preset.

Testing Instructions

Create a custom Administrator menu
Display the default Preset menu in the Admin menu module.
Then switch to the Alternative preset.

No + sign (quickstart) for the items concerned

patch and test again.

test clicking the + sign to confirm it does what it should.

After patch

for both presets

For the custom administrator menu:
Screen Shot 2019-11-11 at 09 50 58

For the administrator modules
Screen Shot 2019-11-11 at 09 52 27

For the alternate preset is also added the quickstart for site modules
Screen Shot 2019-11-11 at 09 54 49

avatar infograf768 infograf768 - open - 11 Nov 2019
avatar infograf768 infograf768 - change - 11 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2019
Category Administration com_menus
avatar infograf768 infograf768 - change - 11 Nov 2019
Labels Added: ?
avatar Quy Quy - test_item - 11 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 11 Nov 2019

I have tested this item successfully on c439284


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27045.

avatar SharkyKZ SharkyKZ - test_item - 13 Nov 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 13 Nov 2019

I have tested this item successfully on 91a59f4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27045.

avatar SharkyKZ SharkyKZ - change - 13 Nov 2019
Status Pending Ready to Commit
avatar SharkyKZ
SharkyKZ - comment - 13 Nov 2019

RTC.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27045.

avatar wilsonge wilsonge - change - 13 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-13 15:45:03
Closed_By wilsonge
Labels Added: ?
avatar wilsonge
wilsonge - comment - 13 Nov 2019

Thanks!

avatar brianteeman
brianteeman - comment - 15 Nov 2019

This PR broke the accessibility of the menu as we now have multiple links with the same name

avatar infograf768
infograf768 - comment - 15 Nov 2019

Can you give an example? And how to test accessibility here.

avatar brianteeman
brianteeman - comment - 15 Nov 2019

you have two links with the same name
"add new module"

avatar infograf768
infograf768 - comment - 15 Nov 2019

Easy enough to solve. We just need to create 2 new strings as I suppose that MOD_MENU_MENU_MANAGER_NEW_MENU_ITEM is also concerned.

On it now.

avatar infograf768
infograf768 - comment - 15 Nov 2019

@brianteeman
Please test #27079

Add a Comment

Login with GitHub to post a comment