? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
8 Nov 2019

Pr for #27025

Testing Instructions

Install multilingual
Go to Content > Categories
Edit Uncategorised
Click Associations button

avatar brianteeman brianteeman - open - 8 Nov 2019
avatar brianteeman brianteeman - change - 8 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2019
Category Administration Language & Strings
avatar Quy
Quy - comment - 8 Nov 2019

Before: Articles: Edit Category
After the alert: Edit Category

avatar brianteeman
brianteeman - comment - 8 Nov 2019

ah - I was just working from the screenshot will update soon

314c6fd 8 Nov 2019 avatar brianteeman $s
avatar brianteeman brianteeman - change - 8 Nov 2019
Labels Added: ? ?
avatar brianteeman
brianteeman - comment - 8 Nov 2019

I have made the change - but - I think you will find that Add Category is also

Before: Articles: AddCategory
After the alert: Add Category

avatar Quy
Quy - comment - 8 Nov 2019

It is now $s: Edit Category. Changed $s to %s, but still an issue.

0c886d8 8 Nov 2019 avatar brianteeman %s
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2019
Category Administration Language & Strings Administration com_categories Language & Strings
avatar brianteeman
brianteeman - comment - 8 Nov 2019

sorry - should work now but please check the Add

avatar Quy
Quy - comment - 8 Nov 2019

Warning: sprintf(): Too few arguments in \libraries\src\Language\Text.php on line 315

438e49b 8 Nov 2019 avatar brianteeman %s
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2019
Category Administration Language & Strings com_categories Administration Language & Strings
avatar brianteeman
brianteeman - comment - 8 Nov 2019

Sorry I am going to revert the last changes back to the original one. I am sure if you check the Add category you will see the same "issue" with before/after

avatar infograf768
infograf768 - comment - 9 Nov 2019

Although we do need that string indeed when a 3rd party component does not have the "normal" string AND I agree with that patch, we should do better than that for core components as the issue is due to an incomplete redirect.

I looked at the urls produced
When first editing the category, we have
administrator/index.php?option=com_categories&view=category&layout=edit&id=2&extension=com_content and we get a nice title

but after reload because Associations could not be performed, we have
administrator/index.php?option=com_categories&view=category&layout=edit&id=2com_content and we get the "COM_CATEGORIES_CATEGORY_BASE_etc"

This is due to an error in the AdminModel.php redirects in the editAssociations($data) method.
Line 1659 on should be

			$extension       = $app->input->get('extension', 'com_content');
			$this->typeAlias = $extension . '.category';
			$extension       = '&extension=' . $extension;

and not only

			$extension       = $app->input->get('extension', 'com_content');
			$this->typeAlias = $extension . '.category';

Will make patch now.

avatar infograf768
infograf768 - comment - 9 Nov 2019

See #27031

avatar infograf768 infograf768 - test_item - 9 Nov 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 9 Nov 2019

I have tested this item successfully on 9e1ca61


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27029.

avatar infograf768
infograf768 - comment - 9 Nov 2019

(Note: looks like we have the same issue in 3.x)

avatar infograf768 infograf768 - change - 9 Nov 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-09 08:24:21
Closed_By infograf768
avatar infograf768 infograf768 - close - 9 Nov 2019
avatar infograf768 infograf768 - merge - 9 Nov 2019
avatar infograf768
infograf768 - comment - 9 Nov 2019

Obvious missing string. Tks.

avatar brianteeman
brianteeman - comment - 9 Nov 2019

Thanks

Add a Comment

Login with GitHub to post a comment