? ? Pending

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
8 Nov 2019

Pull Request for Issue #27017 (comment)

Summary of Changes

In 3b93c7c#diff-2aa7782ed45d0b90a0cc2b6fbd85fd19 was introduced a variable preventing to display the message in Associations tab when the item language is set to All

Testing Instructions

Install a multilingual site
Create and save an article, a category, a contact, a newsfeed, a menu item, with language set to ALL.
Edit these items and display the Associations tab.

Before patch

Screen Shot 2019-11-08 at 12 03 56

After patch

Screen Shot 2019-11-08 at 12 01 34

avatar infograf768 infograf768 - open - 8 Nov 2019
avatar infograf768 infograf768 - change - 8 Nov 2019
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2019
Category ⇒ Administration com_categories com_contact com_content com_menus com_newsfeeds
avatar infograf768 infograf768 - change - 8 Nov 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 8 Nov 2019
The description was changed
avatar infograf768 infograf768 - edited - 8 Nov 2019
7a43b32 8 Nov 2019 avatar infograf768 oops
avatar Quy
Quy - comment - 8 Nov 2019

Probably beyond the scope of this PR that the message be displayed in the box below it or remove the box.

avatar richard67
richard67 - comment - 8 Nov 2019

@Quy For me it is ok: The alert is shown where alerts shall be shown, and the associations box is there where it always is but empty. I think this is consistent.

avatar Quy Quy - test_item - 8 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 8 Nov 2019

I have tested this item ✅ successfully on 43569af


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27023.

avatar richard67 richard67 - test_item - 8 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 8 Nov 2019

I have tested this item ✅ successfully on 43569af

In addition to testing instructions, tested that the notice is not shown for an item which does not have associations but is set to a specific language (i.e. not "All").


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27023.

avatar richard67 richard67 - change - 8 Nov 2019
Status Pending ⇒ Ready to Commit
avatar richard67
richard67 - comment - 8 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27023.

avatar HLeithner HLeithner - change - 9 Nov 2019
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2019-11-09 07:36:29
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 9 Nov 2019
avatar HLeithner HLeithner - merge - 9 Nov 2019
avatar HLeithner
HLeithner - comment - 9 Nov 2019

Thanks

Add a Comment

Login with GitHub to post a comment