[#27020] - [4.0] Download Keys quick icon could crash the site
- Fixed in Code Base
- 8 Nov 2019
- Medium
- Build: 4.0-dev
- # 27020
- Diff
- nikosdion:patch-1
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
If there is a leftover update site from an extension you've removed or, more generally, the extension's XML manifest is no longer present the site breaks because of the Download Keys quick icon plugin.
The problem is that InstallerHelper::getInstallationXML() calls simplexml_load_file and always expect a SimpleXMLElement object. On load failure the simplexml_load_file function returns false.
Fixed by changing the method signature to expect SimpleXMLElement or null and converting a false result into null. The rest of the core works as-is.
Testing Instructions
Install an extension with an update site.
Delete its manifest XML file.
Expected result
The site continues to work.
Actual result
The site crashes with a PHP error.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_installer |
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-08 14:39:12 |
| Closed_By | ⇒ | wilsonge |
Merging on review