User tests: Successful: Unsuccessful:

avatar nikosdion
8 Nov 2019

Summary of Changes

If there is a leftover update site from an extension you've removed or, more generally, the extension's XML manifest is no longer present the site breaks because of the Download Keys quick icon plugin.

The problem is that InstallerHelper::getInstallationXML() calls simplexml_load_file and always expect a SimpleXMLElement object. On load failure the simplexml_load_file function returns false.

Fixed by changing the method signature to expect SimpleXMLElement or null and converting a false result into null. The rest of the core works as-is.

Testing Instructions

Install an extension with an update site.

Delete its manifest XML file.

Expected result

The site continues to work.

Actual result

The site crashes with a PHP error.

Documentation Changes Required


avatar nikosdion nikosdion - open - 8 Nov 2019
avatar nikosdion nikosdion - change - 8 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Nov 2019
Category Administration com_installer
avatar wilsonge wilsonge - change - 8 Nov 2019
Labels Added: ?
avatar wilsonge
wilsonge - comment - 8 Nov 2019

Merging on review

avatar wilsonge wilsonge - change - 8 Nov 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-08 14:39:12
Closed_By wilsonge
avatar wilsonge wilsonge - close - 8 Nov 2019
avatar wilsonge wilsonge - merge - 8 Nov 2019

Add a Comment

Login with GitHub to post a comment