[#27000] - [4.0] Fix progressive cache
- Fixed in Code Base
- 6 Nov 2019
- Medium
- Build: 4.0-dev
- # 27000
- Diff
- wilsonge:fix_cache_progressive_error
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Successor Pull Request for Issue #26262 .
Summary of Changes
Only uses the class of the object to serialize for the cache key. With some help from @mbabker (thankyou!!) debugging this it turned out to be an indirect issue from the introduction of Web Assets as they sit in JDocument (a property of the DocumentRenderer class which in turn has a child of the dispatcher which contains Closures).
There's no relevant in the class contents for the module rendering at this point so no issues with this.
Testing Instructions
Go into your websites backend
Go to the Global Configuration
Go to the system tag
Set the System Cache to "ON-Progressive Caching"
Go to your sites frontend
Now you should get an error-message
Now apply patch and redo the Testing Instructions
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27000.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27000.
Drone error (mysql system test) seems not to be related.
I kept restarting the job until it passed
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-06 00:01:08 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
I have tested this item✅ successfully on ae158f7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/27000.