NPM Resource Changed ? ? Pending

User tests: Successful: Unsuccessful:

avatar Quy
Quy
5 Nov 2019

Pull Request for Issue #26703 .

Summary of Changes

26703

PR fixes margins causing the horizontal scrollbar in medial modal.
.row and .media-container are essentially the same except for margins.
Ideally, use .row in Media page and use .media-container in media modal.

Testing Instructions

Go to Content > Articles
Edit an article
Click Images and Links tab
Click Select button
See horizontal scrollbar
Apply PR
Run npm i
Clear browser's cache
No horizontal scrollbar

avatar Quy Quy - open - 5 Nov 2019
avatar Quy Quy - change - 5 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Nov 2019
Category Administration com_media NPM Change
avatar infograf768 infograf768 - test_item - 5 Nov 2019 - Tested successfully
avatar infograf768
infograf768 - comment - 5 Nov 2019

I have tested this item successfully on 24b92fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26988.

avatar richard67 richard67 - test_item - 5 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 5 Nov 2019

I have tested this item successfully on 24b92fc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26988.

avatar richard67 richard67 - change - 5 Nov 2019
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 5 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26988.

avatar Quy Quy - change - 6 Nov 2019
Labels Added: ?
avatar infograf768 infograf768 - change - 6 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-06 06:44:42
Closed_By infograf768
Labels Added: NPM Resource Changed ?
avatar infograf768 infograf768 - close - 6 Nov 2019
avatar infograf768 infograf768 - merge - 6 Nov 2019
avatar infograf768
infograf768 - comment - 6 Nov 2019

tks

Add a Comment

Login with GitHub to post a comment