? Pending

User tests: Successful: Unsuccessful:

avatar SharkyKZ
SharkyKZ
4 Nov 2019

Pull Request for Issue #26970 (comment) .

Summary of Changes

Fixes condition in query when filtering and searching users.

Testing Instructions

Open user list.
Set some filter and enter a keyword to search by.

Expected result

Users filtered by keywords AND filters.

Actual result

User filtered by keywords OR filters.

Documentation Changes Required

No.

avatar SharkyKZ SharkyKZ - open - 4 Nov 2019
avatar SharkyKZ SharkyKZ - change - 4 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2019
Category Administration com_users
avatar richard67
richard67 - comment - 4 Nov 2019

Hint for testers: Don't use the "never" filter for the last visit date for the test. There is another mistake for which I am currently working on a correction.

avatar richard67
richard67 - comment - 4 Nov 2019

2nd hint: The problem appears only with the date range filters for registered date and last visit date (of which the "never" filter for last visit date still needs a correction, see my previous comment). With other filters the problem does not appear.

avatar richard67 richard67 - test_item - 4 Nov 2019 - Tested successfully
avatar richard67
richard67 - comment - 4 Nov 2019

I have tested this item successfully on 7ca2a5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26981.

avatar richard67
richard67 - comment - 4 Nov 2019

I have tested this item successfully on 7ca2a5c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26981.

avatar richard67
richard67 - comment - 4 Nov 2019

@SharkyKZ I just see there are PHPCS issues reported by drone.

b85347a 4 Nov 2019 avatar SharkyKZ CS
avatar SharkyKZ SharkyKZ - change - 4 Nov 2019
Labels Added: ?
avatar richard67
richard67 - comment - 4 Nov 2019

@SharkyKZ Maybe we should combine this PR and my new one #26982 ? Or better keep it separate?

avatar SharkyKZ
SharkyKZ - comment - 4 Nov 2019

Sure, why not. Submitted richard67#14.

avatar SharkyKZ SharkyKZ - change - 4 Nov 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-11-04 20:54:54
Closed_By SharkyKZ
avatar SharkyKZ SharkyKZ - close - 4 Nov 2019
avatar richard67
richard67 - comment - 4 Nov 2019

@SharkyKZ Thanks a lot. That will simplify things with testing because both errors can influence each other.

I worry we might have this "orWhere" problem at other places, too, that after that some other where is added or not, depending on filters.

avatar SharkyKZ
SharkyKZ - comment - 4 Nov 2019

Making PR for other places now.

Add a Comment

Login with GitHub to post a comment