[#26964] - [4.0] Fix last visit older than 1 year filter in users model
- Fixed in Code Base
- 3 Nov 2019
- Medium
- Build: 4.0-dev
- # 26964
- Diff
- richard67:4.0-dev-fix-users-last-visit-older-year-filter
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #26611 (comment).
Summary of Changes
This Pull Request (PR) fixes the filter "More than 1 year go" in the users list view, which was broken with my PR #26611 (blush).
Testing Instructions
- On a clean installation of current 4.0-dev or the latest nightly 4.0-beta1-dev build of tonight, go to "Users -> Manage" in backend.
- Click Filter Options and select "Last Visit Date -> More than a year ago".
Expected result
List is shown with the selected filter applied.
Actual result
Error "500 No data supplied for parameters in prepared statement No data supplied for parameters in prepared statement".
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
| Easy | No | ⇒ | Yes |
| Easy | Yes | ⇒ | No |
merged by code review, thx
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-03 12:56:39 |
| Closed_By | ⇒ | HLeithner |
Thanks.
Please check again when Last Visit Date and Registration Date are selected.
Call stack
--
# | Function | Location
1 | () | JROOT\administrator\components\com_users\View\Users\HtmlView.php:107
2 | Joomla\Component\Users\Administrator\View\Users\HtmlView->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:690
3 | Joomla\CMS\MVC\Controller\BaseController->display() | JROOT\administrator\components\com_users\Controller\DisplayController.php:120
4 | Joomla\Component\Users\Administrator\Controller\DisplayController->display() | JROOT\libraries\src\MVC\Controller\BaseController.php:728
5 | Joomla\CMS\MVC\Controller\BaseController->execute() | JROOT\libraries\src\Dispatcher\ComponentDispatcher.php:146
6 | Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() | JROOT\libraries\src\Component\ComponentHelper.php:383
7 | Joomla\CMS\Component\ComponentHelper::renderComponent() | JROOT\libraries\src\Application\AdministratorApplication.php:117
8 | Joomla\CMS\Application\AdministratorApplication->dispatch() | JROOT\libraries\src\Application\AdministratorApplication.php:160
9 | Joomla\CMS\Application\AdministratorApplication->doExecute() | JROOT\libraries\src\Application\CMSApplication.php:242
10 | Joomla\CMS\Application\CMSApplication->execute() | JROOT\administrator\includes\app.php:63
11 | require_once() | JROOT\administrator\index.php:36
``
I get a 500 but no error message.
And which filter? also "more than one year ago"?
Same filter. It doesn't matter as long as you select from Last Visit Date and Registration Date.
I have it .. PR is on the way. Please be ready for test.
Drone failure (mysql system test) seems not to be related to this PR.