? Pending

User tests: Successful: Unsuccessful:

avatar mangeshmane
mangeshmane
2 Nov 2019

Pull Request for Issue #26905

avatar mangeshmane mangeshmane - open - 2 Nov 2019
avatar mangeshmane mangeshmane - change - 2 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2019
Category Administration com_associations
avatar mangeshmane mangeshmane - change - 2 Nov 2019
Title
Joomla 4 local
Multilingual Associations :Association > Hide Reference and Select Target buttons placement and font is not correct
avatar mangeshmane mangeshmane - edited - 2 Nov 2019
avatar infograf768
infograf768 - comment - 2 Nov 2019

I am not in favor of this patch.
This reduces the Select Target button and not increase the Hide/Show Reference button.

If judged necessary to normalize these buttons size, it should rather be an increase for the Hide/Show Reference button and NOT reduce the Select Target one.

This should be done by taking off btn-sm in the edit.php file line 33
<button id="toogle-left-panel" class="btn btn-sm btn-secondary"

Note: I am not sure it is necessary at all.
As for the alignment matter as asked in #26905 it is quite difficult or maybe impossible as we have 2 Iframes and the Hide/Show Reference button has to remain out of the IFrame.

avatar Quy
Quy - comment - 9 Nov 2019

Would moving these 2 buttons to the toolbar be a solution?

avatar infograf768
infograf768 - comment - 9 Nov 2019

Would moving these 2 buttons to the toolbar be a solution?

Not sure about that as we may have 3 buttons and anyway a field for language concerning Target.
Screen Shot 2019-11-09 at 09 35 49

avatar Quy
Quy - comment - 17 Nov 2019

Moving Change Target and Clear buttons next to Select Target Language dropdown will fix the alignment.

avatar infograf768
infograf768 - comment - 17 Nov 2019

It is easy to regroup the 2 buttons with the field.
I can easily get this

Screen Shot 2019-11-17 at 10 38 48

And I can tweak it when reducing window size for the Select Target Language field

Remains to align them to Hide/Show Reference button
I could obtain this

Screen Shot 2019-11-17 at 10 27 14

But after Hiding reference I would get

Screen Shot 2019-11-17 at 10 30 23

and it would break in mobile view...

Screen Shot 2019-11-17 at 10 32 27

Putting them in toolbar would put the button fields very far way from the Target in mobile view.
Not a good idea imho.

avatar Quy
Quy - comment - 17 Nov 2019

How about leaving the drop down as it but moving the 2 buttons to the right of it?

avatar infograf768
infograf768 - comment - 17 Nov 2019

How about leaving the drop down as it but moving the 2 buttons to the right of it?

You mean solution one and just inverse the order?

avatar Quy
Quy - comment - 17 Nov 2019

Keep it how it is now, but move the 2 buttons to the right of the drop down. Target would be above the drop down and buttons.

avatar infograf768
infograf768 - comment - 18 Nov 2019

You mean something like this?
assoctarget2

avatar Quy
Quy - comment - 18 Nov 2019

Yes, perfect! Maybe add a bottom margin to separate the dropdown/buttons from the box below.

avatar infograf768
infograf768 - comment - 20 Nov 2019

PR ready (including RTL) but I wonder.
In 3.x the reason why we added the button and language dropdown next to Target was to align the various fields in Reference and Target to make it easier to compare/modify.
When they are presented the way above (+ the margin) they lose this alignment.
Therefore the only way would be to create a margin-top for the Reference iframe which would be equal to the place used by the buttons in Target. That is possible but we would get a blank space.

Screen Shot 2019-11-20 at 06 57 17

Note: I also found an issue for the clear button as someone changed a lot of stuff in J4, i.e. the Clear button is supposed to undo the displayed association but also to clear totally the Target part. It does not do that anymore, even when we correct the call to the wrong js in the AssociationField type.

avatar Quy
Quy - comment - 20 Nov 2019

Field alignment takes precedence so the blank line will have to be.

avatar infograf768
infograf768 - comment - 21 Nov 2019

@Quy
Please test #27111

closing this one.

avatar infograf768 infograf768 - change - 21 Nov 2019
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2019-11-21 08:21:43
Closed_By infograf768
Labels Added: ?
avatar infograf768 infograf768 - close - 21 Nov 2019

Add a Comment

Login with GitHub to post a comment