User tests: Successful: Unsuccessful:
Pull Request for Issue #26749
Taking into account both int and string possibility to display No and Hide to be B/C
Display Global Configuration
Status | New | ⇒ | Pending |
Category | ⇒ | Layout |
I have tested this item
#pbf19 #test1
I have tested this item
#pbf19 #test2
Status | Pending | ⇒ | Ready to Commit |
RTC
Doesn't work with float-like values.
Labels |
Added:
?
?
|
Title |
|
Please view configuration.php
. Look for settings with true
and false
values.
Under System > System Information > Configuration File
, true
and false
are displayed as 1
as a string and empty string respectively.
Therefore, you only need to check for empty string (false
) and assign it 0
as a string which is a simpler fix.
$value = $value === '' ? '0' : $value ;
$checked = ((string) $option->value == $value) ? 'checked="checked"' : '';
$active = ((string) $option->value == $value) ? 'class="active"' : '';
Status | Ready to Commit | ⇒ | Pending |
Labels |
Removed:
?
|
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
rtc
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Pending |
Removed RTC to address Harald's comment.
what this pr still need to do to became RTC ? unable to find
Harald's comment.
Discussion in Glip. This PR forces empty string to be 0 which does not allow the case when a value should be an empty string.
In what scenario would a radio have an empty string value
@HLeithner
Please comment.
Labels |
Removed:
?
|
@brianteeman for example if the value should be empty^^
<select><option value="">JNONE</option><option value="enlightenment">JENLIGHTENMENT</option></select>
For me I don't understand why it should not be possible to have an empty value.
@brianteeman In Global Configuration. Radio fields with 0/1 values are stored as booleans in configuration.php
. When cast as string false
becomes an empty string.
By definition one item in a radio should always have a value unlike a checkbox- or am I completely missing the point here
An empty value is not invalid.
Shall this be closed?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-19 15:03:10 |
Closed_By | ⇒ | Quy |
I have tested this item✅ successfully on fe97446
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26908.