User tests: Successful: Unsuccessful:
Replace the Bootstrap tabs on the Global Config page with Custom Elements.
administrator/index.php?option=com_config
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_config |
Yeah just noticed. Trying to sort it now.
Labels |
Added:
?
|
@brianteeman think it's done now. Not sure if anything is missing cause the view was a mess, beyond belief.
Well the scrollbar didn't appear with the b's tabs
All I'm doing it using the Custom Elements for the tabs. If there are styling issues, they need to be fixed in the CE repo.
A lot of tabs would result in a scrollbar in other pages that are already using the tabs, not just this page
Spacing is there due to it being rendered with renderFieldset()
which wraps it inside <div class="controls">
. Not sure if there is another method to render it.
@C-Lodder please add the todo for the showon
as #23780 (review)
I have tested this item
I have tested this successfully. #jpbf19 #test1
I have tested this item
Well the scrollbar didn't appear with the b's tabs
The scrollbars are part of the tabs design (but should be visible only on smaller screens). The idea comes from https://bulma.io/documentation/components/tabs/
@Quy Thanks for the commit. Much appreciated
@brianteeman would you mind giving it another spin please?
I have tested this item
@brianteeman just a reminder if you find any time to do a quick test
Sorry. Completely forgot
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-11-24 18:08:00 |
Closed_By | ⇒ | wilsonge |
Thanks!
I have tested this item
Testing this on last Nightly Build (ie 25/11).
@C-Lodder Fact is that the global config fields are more broken now as before, like @ghazal 's screenshot shows in his comment above. This is not really obvious in #25891 , so I think either it needs a new screenshot in the description of #25891so people can see it deals also with the issue shown by @ghazal , or someone has to create a new issue, so people can see it is known. If new issue and nobody has the time to create one: I can do that, just let me know.
tested and it works but you also need to do the tabs in ?option=com_config&view=component