? ? Pending

User tests: Successful: Unsuccessful:

avatar C-Lodder
C-Lodder
1 Nov 2019

Fixes

#25876

Summary of Changes

Replace the Bootstrap tabs on the Global Config page with Custom Elements.

Testing Instructions

  1. Go to administrator/index.php?option=com_config
  2. Navigate through the tabs and ensure they display the correct content
avatar C-Lodder C-Lodder - open - 1 Nov 2019
avatar C-Lodder C-Lodder - change - 1 Nov 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2019
Category Administration com_config
avatar C-Lodder C-Lodder - change - 1 Nov 2019
The description was changed
avatar C-Lodder C-Lodder - edited - 1 Nov 2019
avatar brianteeman
brianteeman - comment - 1 Nov 2019

tested and it works but you also need to do the tabs in ?option=com_config&view=component

avatar C-Lodder
C-Lodder - comment - 1 Nov 2019

Yeah just noticed. Trying to sort it now.

avatar C-Lodder C-Lodder - change - 1 Nov 2019
Labels Added: ?
avatar C-Lodder
C-Lodder - comment - 1 Nov 2019

@brianteeman think it's done now. Not sure if anything is missing cause the view was a mess, beyond belief.

avatar brianteeman
brianteeman - comment - 1 Nov 2019
  1. think you got it everywhere now

  2. check the permissions tab as it now has a big indent again
    image

  3. on a page with a lot of tabs is it supposed to have a scroll bar?
    image

avatar C-Lodder
C-Lodder - comment - 1 Nov 2019
  1. The permissions tabs are another issues. I'll fix them in this PR so it's not forgotten about.
  2. Not sure about the scrollbar, but nothing to do with this PR.
avatar brianteeman
brianteeman - comment - 1 Nov 2019

Well the scrollbar didn't appear with the b's tabs

avatar C-Lodder
C-Lodder - comment - 1 Nov 2019

All I'm doing it using the Custom Elements for the tabs. If there are styling issues, they need to be fixed in the CE repo.

A lot of tabs would result in a scrollbar in other pages that are already using the tabs, not just this page

avatar C-Lodder
C-Lodder - comment - 1 Nov 2019

Spacing is there due to it being rendered with renderFieldset() which wraps it inside <div class="controls">. Not sure if there is another method to render it.

avatar richard67
richard67 - comment - 1 Nov 2019
2. The permissions tabs are another issues. I'll fix them in this PR so it's not forgotten about.

@C-Lodder So we shall wait with testing this PR until you've added that, too?

avatar dgrammatiko
dgrammatiko - comment - 1 Nov 2019

@C-Lodder please add the todo for the showon as #23780 (review)

avatar vaibhavsTekdi vaibhavsTekdi - test_item - 2 Nov 2019 - Tested successfully
avatar vaibhavsTekdi
vaibhavsTekdi - comment - 2 Nov 2019

I have tested this item successfully on 1ed6b47

I have tested this successfully. #jpbf19 #test1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

avatar ttplpoojak ttplpoojak - test_item - 2 Nov 2019 - Tested successfully
avatar ttplpoojak
ttplpoojak - comment - 2 Nov 2019

I have tested this item successfully on 1ed6b47


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

avatar dgrammatiko
dgrammatiko - comment - 2 Nov 2019

Well the scrollbar didn't appear with the b's tabs

The scrollbars are part of the tabs design (but should be visible only on smaller screens). The idea comes from https://bulma.io/documentation/components/tabs/

avatar C-Lodder
C-Lodder - comment - 2 Nov 2019

@mbabker do you know of another way to render the permissions element without renderFieldSet() ?

avatar C-Lodder
C-Lodder - comment - 3 Nov 2019

@Quy Thanks for the commit. Much appreciated

@brianteeman would you mind giving it another spin please?

avatar brianteeman
brianteeman - comment - 3 Nov 2019

@C-Lodder I am away this weekend without a laptop.

avatar Quy Quy - test_item - 3 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 3 Nov 2019

I have tested this item successfully on a29d7fd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

avatar C-Lodder
C-Lodder - comment - 12 Nov 2019

@brianteeman just a reminder if you find any time to do a quick test

avatar brianteeman
brianteeman - comment - 12 Nov 2019

Sorry. Completely forgot

avatar brianteeman brianteeman - test_item - 12 Nov 2019 - Tested successfully
avatar brianteeman
brianteeman - comment - 12 Nov 2019

I have tested this item successfully on 9d08410


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

avatar Quy Quy - test_item - 12 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 12 Nov 2019

I have tested this item successfully on 9d08410


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

avatar Quy Quy - change - 12 Nov 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 12 Nov 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

avatar Quy Quy - change - 12 Nov 2019
Labels Added: ?
avatar wilsonge wilsonge - change - 24 Nov 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-11-24 18:08:00
Closed_By wilsonge
avatar wilsonge wilsonge - close - 24 Nov 2019
avatar wilsonge wilsonge - merge - 24 Nov 2019
avatar wilsonge
wilsonge - comment - 24 Nov 2019

Thanks!

avatar ghazal ghazal - test_item - 25 Nov 2019 - Tested unsuccessfully
avatar ghazal
ghazal - comment - 25 Nov 2019

I have tested this item ? unsuccessfully on 29f07de

Testing this on last Nightly Build (ie 25/11).


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26890.

global-config

avatar wilsonge
wilsonge - comment - 25 Nov 2019

@ghazal given this got merged last night can you create a fresh issue for your bug so that it can be tracked properly - thanks!

avatar C-Lodder
C-Lodder - comment - 25 Nov 2019

@wilsonge @ghazal The overlapping has nothing to do with this PR. The fields inside the parent should respond to the width of the parent.

I have already raised an issue about the poor UX with fieldsets.....the fact the labels are to the left of the field and the sets are spanned horizontally.

avatar ghazal
ghazal - comment - 25 Nov 2019

@C-Lodder
Should I let you create the PR ?
Most probably your description will be more detailed than mine.
@wilsonge

avatar C-Lodder
C-Lodder - comment - 25 Nov 2019

@ghazal I think the powers that be seem to be happy with the current horizontal layout. I'll let the issue I raised speak for itself once there's more feedback on it: #25891

avatar richard67
richard67 - comment - 28 Nov 2019

@C-Lodder Fact is that the global config fields are more broken now as before, like @ghazal 's screenshot shows in his comment above. This is not really obvious in #25891 , so I think either it needs a new screenshot in the description of #25891so people can see it deals also with the issue shown by @ghazal , or someone has to create a new issue, so people can see it is known. If new issue and nobody has the time to create one: I can do that, just let me know.

Add a Comment

Login with GitHub to post a comment