[#26875] - [com_banners] Avoid running the query when no keywords are provided
- Fixed in Code Base
- 5 Dec 2019
- Medium
- Build: staging
- # 26875
- Diff
- SharkyKZ:j3/query/com_banners
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
When filtering by keywords but no keywords are provided com_banners runs a query that always returns no results. We can avoid running such query.
This also fixes query error on PostgreSQL and MS SQL described in #26789.
Testing Instructions
Create some banners.
Publish a banner module.
Enable filtering by keywords in module.
Inspect the module when meta keywords are set and not set.
Expected result
When keywords are set, banners appear like before.
When keywords are not set, banners don't appear (like before) and there's 1 query less.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_banners |
| Labels |
Added:
?
|
||
@SharkyKZ i've submitted mine #26791 to you branch SharkyKZ#7 should be better to have 1 pr touching the same file, without don't work on postgresql/ms sql for the regexp issue
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26875.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26875.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26875.
| Labels |
Added:
?
|
||
Thanks for the optimization.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-12-05 22:07:59 |
| Closed_By | ⇒ | HLeithner |
I have tested this item✅ successfully on df78b37
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26875.