? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
30 Oct 2019

Pull Request for Issue #26846

Summary of Changes

added missed import of use Joomla\CMS\Language\Text;

Testing Instructions

see #26846 or
code review

avatar alikon alikon - open - 30 Oct 2019
avatar alikon alikon - change - 30 Oct 2019
Status New Pending
bc53c76 30 Oct 2019 avatar alikon once
avatar alikon alikon - change - 30 Oct 2019
Labels Added: ?
avatar Quy Quy - test_item - 30 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 30 Oct 2019

I have tested this item successfully on bc53c76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26864.

avatar brianteeman brianteeman - test_item - 30 Oct 2019 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 30 Oct 2019

I have tested this item ? unsuccessfully on bc53c76

I am still getting

        "title": "Save failed with the following error: COM_CONTACT_ERROR_UNIQUE_ALIAS"

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26864.
avatar alikon
alikon - comment - 30 Oct 2019

you are right it doesn't solve #26846 .....i'll reopen it
anyway this pr have a sense filling the missing library

avatar alikon alikon - change - 30 Oct 2019
The description was changed
avatar alikon alikon - edited - 30 Oct 2019
avatar brianteeman
brianteeman - comment - 30 Oct 2019

the problem is not with the use statement. In joomla we had 2 applications and therefore we had a language folder in each application (site and administrator). We now have an additional application (api) and so we should really have an application language folder. It is not enough to proxy to either the site or the administrator folder as the strings could be in either.

avatar alikon
alikon - comment - 30 Oct 2019

don't forget the CLI too ?

avatar alikon
alikon - comment - 30 Oct 2019

i've raised this "general" problem on the jbs glip channel, but unfortunately you are not in there....grrr
we have got some feedback..... about reverting #12124 as a quick fix....

avatar brianteeman
brianteeman - comment - 30 Oct 2019

I doubt very much that #12124 will have any impact on this at all

avatar alikon
alikon - comment - 30 Oct 2019

well, right now i dunno, i need to check, but the "one" who proposed this quick fix, was the "one who wrote that pr ...so i'm inclined to give it a try ?

avatar wilsonge
wilsonge - comment - 31 Oct 2019

That PR isn't the fix. It's what @brianteeman says (I tested this with him in the pub on Tuesday night). I need to dig around in the code to actually prove why though

avatar wilsonge wilsonge - change - 31 Oct 2019
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-31 07:55:53
Closed_By wilsonge
avatar wilsonge wilsonge - close - 31 Oct 2019
avatar wilsonge wilsonge - merge - 31 Oct 2019
avatar wilsonge
wilsonge - comment - 31 Oct 2019

Clearly imports are missing here though - so merging this! Thanks!

Add a Comment

Login with GitHub to post a comment