[#26860] - Minor CSS changes
- Closed
- 12 Jan 2020
- Medium
- Build: 4.0-dev
- # 26860
- Diff
- spahno:CSS
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
-added generic default for font property
-replaced styling properties with padding shorthand
Testing Instructions
Install the 4.0-dev
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26860.
@brianteeman what part of this was unsuccessful for you?
one of those PR that just moving things around :)
As far as I am concerned having a serif font as a fallback to a sans-serif font is not correct.
Another point is that it will never fail to serif, because every system has sans serif.
Such "deep" fallback make sense only for web-fonts. For a local fonts like Arial, Helvetica it have 0 sense.
because every system has sans serif
Not true. It's a very high percentage, but not 100%.
So what is the verdict...remove serif?
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-01-12 00:43:57 |
| Closed_By | ⇒ | Quy |
Please test PR #27488 without the font-family change.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26860.
I have tested this item✅ successfully on bc897ca
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26860.