? ? Pending

User tests: Successful: Unsuccessful:

avatar vlaucht
vlaucht
29 Oct 2019

Pull Request for Issue #26817

Summary of Changes

Background of system message container has been removed

Testing Instructions

apply PR
run npm i
Do something that will create multiple alerts. eg install a patch with com_patchtesters

Expected result

Background of container should be transparent

Documentation Changes Required

none

avatar vlaucht vlaucht - open - 29 Oct 2019
avatar vlaucht vlaucht - change - 29 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 29 Oct 2019
Category Administration Templates (admin)
avatar vlaucht vlaucht - change - 29 Oct 2019
Labels Added: ?
avatar dgrammatiko
dgrammatiko - comment - 29 Oct 2019

Can you please make these changes against #26077
You see there is a very wrong approach considering the css as a monolith and also it’s against the joomla’s intended way...

avatar BertaOctech BertaOctech - test_item - 15 Nov 2019 - Tested unsuccessfully
avatar BertaOctech
BertaOctech - comment - 15 Nov 2019

I have tested this item ? unsuccessfully on dbecdc4

I applied a random patch to observe the effect and the revert the patch. Infact the space between messages was not transparent
Then I applied the patch and applied a second patch to observe the messages.

I am afraid nothing changed.

I am using Firefox on suseLinux


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26855.

avatar Quy
Quy - comment - 9 Dec 2019

@dgrammatiko Is this still a valid fix?

avatar dgrammatiko
dgrammatiko - comment - 9 Dec 2019

@Quy yes! but the PR needs to be updated (we moved the alert code to it's own file, the comment I made above)

avatar Quy
Quy - comment - 2 Jan 2020

Please test PR #27394

avatar Quy Quy - change - 2 Jan 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-01-02 21:33:54
Closed_By Quy
Labels Added: ?
avatar Quy Quy - close - 2 Jan 2020

Add a Comment

Login with GitHub to post a comment