? ? Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
28 Oct 2019

Pull Request for Issue #26291

Summary of Changes

Add class vars and remove 2.5 fallback

Testing Instructions

make sure the plugin still works than expected

Expected result

cleaner code

Actual result

missing class vars and un needed 2.5er fallback

Documentation Changes Required

none

avatar zero-24 zero-24 - open - 28 Oct 2019
avatar zero-24 zero-24 - change - 28 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2019
Category Front End Plugins
avatar SharkyKZ SharkyKZ - test_item - 29 Oct 2019 - Tested successfully
avatar SharkyKZ
SharkyKZ - comment - 29 Oct 2019

I have tested this item successfully on d93325b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26851.

avatar Quy Quy - test_item - 29 Oct 2019 - Tested successfully
avatar Quy
Quy - comment - 29 Oct 2019

I have tested this item successfully on d93325b


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26851.

avatar Quy Quy - change - 29 Oct 2019
Status Pending Ready to Commit
avatar Quy
Quy - comment - 29 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26851.

avatar Quy
Quy - comment - 29 Oct 2019

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26851.

avatar wilsonge wilsonge - change - 31 Oct 2019
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2019-10-31 09:38:41
Closed_By wilsonge
Labels Added: ? ?
avatar wilsonge wilsonge - close - 31 Oct 2019
avatar wilsonge wilsonge - merge - 31 Oct 2019
avatar wilsonge
wilsonge - comment - 31 Oct 2019

Thanks!

avatar zero-24
zero-24 - comment - 31 Oct 2019

Thanks.

Add a Comment

Login with GitHub to post a comment