User tests: Successful: Unsuccessful:
Pull Request for Issue # .
#26702
vertically centered the joomla logo on installation page
Install the 4.0-dev, Installation Spinner after Database settings should be centered
none
Status | New | ⇒ | Pending |
Category | ⇒ | Repository NPM Change |
Not tested, but
top: -15%;
doesn't seem right.
align-items: center; vertically centered the box on the screen, but the box is rotated by 45 degrees, and the center of the logo is not the center of the box, so I had to offset it by -15%
I have tested this item
Yup, thought it wouldn't work. Percentages (top: -15%
) should not be used to vertically align something
Open for other suggestions. As seen in the Screenshot, the Box is vertically centered, but the logo is not centered to the box.
The spacing as mentioned by @C-Lodder only happens if the viewport size is reduced to the height of the logo, and its even worse if the offset is removed
212px would be half the height of the box. The Logo doesn't start at exactly half the box, so I guess offsetting it by roughly -150px would do the trick as well
I believe the issue is simply due to the size of the spans, in conjunction with the box dimensions
Labels |
Added:
NPM Resource Changed
?
|
Now the logo should be centered in the box
I'd suggest reverting your changes and instead adding translate(-25%, -25%)
to this transform...
It should save you all the messing with margins.
I'd suggest reverting your changes and instead adding
translate(-25%, -25%)
to this transform...It should save you all the messing with margins.
yep, tested it and it works. Should be fine now
I have tested this item
I have tested this item
After applying PR, the logo is not vertically centered.
It is centered for me in Firefox and Chrome on Windows. Please advise your browser.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2020-04-30 17:46:46 |
Closed_By | ⇒ | Quy |
Not tested, but
top: -15%;
doesn't seem right.