NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar vlaucht
vlaucht
28 Oct 2019

Pull Request for Issue # .
#26702

Summary of Changes

vertically centered the joomla logo on installation page

Testing Instructions

Install the 4.0-dev, Installation Spinner after Database settings should be centered

Documentation Changes Required

none

avatar vlaucht vlaucht - open - 28 Oct 2019
avatar vlaucht vlaucht - change - 28 Oct 2019
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Oct 2019
Category Repository NPM Change
avatar C-Lodder
C-Lodder - comment - 28 Oct 2019

Not tested, but top: -15%; doesn't seem right.

avatar vlaucht
vlaucht - comment - 28 Oct 2019

Not tested, but top: -15%; doesn't seem right.

align-items: center; vertically centered the box on the screen, but the box is rotated by 45 degrees, and the center of the logo is not the center of the box, so I had to offset it by -15%

avatar brianteeman
brianteeman - comment - 28 Oct 2019

tested this in two places. Installation and when you create a field. In both cases you can see that it is not centered

chrome_2019-10-28_15-30-45

chrome_2019-10-28_15-34-14

avatar brianteeman brianteeman - test_item - 28 Oct 2019 - Tested unsuccessfully
avatar brianteeman
brianteeman - comment - 28 Oct 2019

I have tested this item 🔴 unsuccessfully on 173ec04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26845.

avatar C-Lodder
C-Lodder - comment - 28 Oct 2019

Yup, thought it wouldn't work. Percentages (top: -15%) should not be used to vertically align something

avatar Quy
Quy - comment - 28 Oct 2019

Tested successfully.

Apply PR.
Run npm i.
Clear browser's cache.
Delete configuration file.
Reinstall.

26845

avatar C-Lodder
C-Lodder - comment - 28 Oct 2019

@Quy Reduce your viewport height and you'll notice spacing at the top:

screeny

avatar vlaucht
vlaucht - comment - 28 Oct 2019

center

Open for other suggestions. As seen in the Screenshot, the Box is vertically centered, but the logo is not centered to the box.
The spacing as mentioned by @C-Lodder only happens if the viewport size is reduced to the height of the logo, and its even worse if the offset is removed

212px would be half the height of the box. The Logo doesn't start at exactly half the box, so I guess offsetting it by roughly -150px would do the trick as well

avatar C-Lodder
C-Lodder - comment - 28 Oct 2019

I believe the issue is simply due to the size of the spans, in conjunction with the box dimensions

avatar vlaucht vlaucht - change - 28 Oct 2019
Labels Added: NPM Resource Changed ?
avatar vlaucht
vlaucht - comment - 28 Oct 2019

Now the logo should be centered in the box

avatar ciar4n
ciar4n - comment - 28 Oct 2019

I'd suggest reverting your changes and instead adding translate(-25%, -25%) to this transform...

It should save you all the messing with margins.

avatar vlaucht
vlaucht - comment - 29 Oct 2019

I'd suggest reverting your changes and instead adding translate(-25%, -25%) to this transform...

It should save you all the messing with margins.

yep, tested it and it works. Should be fine now

avatar Quy Quy - test_item - 5 Nov 2019 - Tested successfully
avatar Quy
Quy - comment - 5 Nov 2019

I have tested this item ✅ successfully on d75b0d4


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26845.

avatar pabloarias
pabloarias - comment - 15 Nov 2019

Not vertically centered.
Screenshot_20191115_202603

avatar jwaisner jwaisner - test_item - 5 Jan 2020 - Tested unsuccessfully
avatar jwaisner
jwaisner - comment - 5 Jan 2020

I have tested this item 🔴 unsuccessfully on 1e2696b

After applying PR, the logo is not vertically centered.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26845.

avatar Quy
Quy - comment - 5 Jan 2020

It is centered for me in Firefox and Chrome on Windows. Please advise your browser.

avatar Quy
Quy - comment - 12 Apr 2020

@ciar4n Can you also look into this? Thanks.

avatar Quy
Quy - comment - 30 Apr 2020

Fixed in PR #28888

avatar Quy Quy - change - 30 Apr 2020
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2020-04-30 17:46:46
Closed_By Quy
avatar Quy Quy - close - 30 Apr 2020

Add a Comment

Login with GitHub to post a comment