Feeling Lucky
?
?
[#26842] - [4.0] Remove horizontal scrollbar in statistics modal
- Fixed in Code Base
- 31 Oct 2019
- Medium
- Build: 4.0-dev
- # 26842
- Diff
- Quy:statistics-popup
- Pending Hound Hound is busy sniffing around... Details
User tests: Successful: Unsuccessful:
Summary of Changes
Use container-popup to remove extra margins resulting in horizontal scrollbar. Make markup consistent with other modals.
Testing Instructions
Go to Components > Smart Search
Click Statistics button
See horizontal scrollbar
Apply PR
No horizontal scrollbar
Actual Results
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder |
infograf768
- comment
- 28 Oct 2019
Note:
- we use
container-popupin many places in core but this class does not exist in css. - The table has no left border. It does not show much when used in the full page but it shows in such popups as background is white.
To solve this I added a border in/administrator/templates/atum/scss/vendor/bootstrap/_table.scss
.table {
box-shadow: 1px 1px 1px 0px rgba(0, 0, 0, 0.25);
border: 1px solid var(--atum-bg-light); // added
What do you think?
| Labels |
Added:
?
|
||
Quy
- comment
- 28 Oct 2019
Within the module and modal, I prefer no right and left borders.
DerTebbe
- comment
- 30 Oct 2019
I have tested this item
Tested successfully
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26842.
| Status | Pending | ⇒ | Ready to Commit |
Quy
- comment
- 30 Oct 2019
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26842.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2019-10-31 13:40:51 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 31 Oct 2019
Thanks!
I have tested this item✅ successfully on 7938fb2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/26842.