article copy to another category don't work, even with non featured article
and i'm testing with mysql

Yes, just tested: With this PR the error goes away and success message is shown, but then I can't see any copied article.
Update: Can't see because it doesn't exist. Copying failed.

even if the article is present in the #__content table
maybe workflow ???

Yes, in DB they exist, the copied ones have state=0. But then I set filter to show also trashed items I don't see them.

No PHP warning or notice or error, nothing in MySQL log.

almost certainly workflow related.

You can strike through the "almost" I would say.

i was being polite

politically incorrect comment "i hate workflow" ?

Question is how we shall coninue with this PR here? It fixes the error "1136 Column count doesn't match value count at row 1" when batch copying a featured article. The general problem we've discovered here, should that be handled in a separate issue?

pr itself is correct imho
anyway the copy issue is workflow related

The general problem we've discovered here, should that be handled in a separate issue?

We can separate if we merge this fast. Otherwise It can be closed and included in the full patch.

I have tested this item ✅ successfully on 22a19e7

Fixes the error "1136 Column count doesn't match value count at row 1" when batch copying a featured article.

Other problems with batch processing are out of scope of this PR.

Modified title to fit.

@alikon My query shows an additional condition:

WHERE ws.condition IN (:preparedArray1,:preparedArray2) AND wa.extension='com_content'

Could this one be the problem? Unfortunately we don't see values of prepared statements in debug.

AFAIK com_content has not been converted to prepared statement.... maybe some MVC libraries...

@infograf768 Please check infograf768#54. It implements @SharkyKZ 's comment that the dates of the copied article shall be used. Unfortunately it does not solve the other, more global problem.

@richard67 See my comment in your PR

I have tested this item ? unsuccessfully on 22a19e7

Everything works normally, and the new article is added to the content and content_froentend table. But, the new article is not shown in the list.

@anibalsanchez
The PR does not solve fully Batch Copy, it only solves the error due to wrong columns for featured_up and featured_down.

Solving fully batch copy will require another PR.

@anibalsanchez Please test again with respect to the comment in my previous test result above:

Fixes the error "1136 Column count doesn't match value count at row 1" when batch copying a featured article.

Other problems with batch processing are out of scope of this PR.

pr itself is correct imho
anyway the copy issue is workflow related

@alikon What happens if you enable again the commented out 3 lines and change the 2 joins from inner join to left join?

I have tested this item ✅ successfully on bff961e

Fixes the error "1136 Column count doesn't match value count at row 1" when batch copying a featured article.

The general problem that batch copied articles are not visible in the list view but exist in the database is not subject of this PR and has to be handled separately.

The reason for the other, general issue is that for the copied items no workflow assiciations are inserted.

Workflow associations are joined for each item with an inner join on the item id in the list query.

So the copied items are not shown because in database they definitely don't have corresponding records in the workflow associations table.

I've just made a PR to @infograf768 's branch to solve the general problem, too. If he wants, he may merge it and change scope of this PR to solve the batch copy problem in general.

But I am not sure if that is the correct final solution. Maybe it was intended that workflow for batch copied items starts from beginning. But then it seems it was not implemented and just nothing was done, i.e. the batch copied items did not have a workflow association. That's fixed if JM merges my PR, and I think for now that's sufficient. Otherwise, if he wants to keep things separate, I can make a new PR here.

Hmm, there seems to be a PR already solving the general issue with batch copy caused by missing workflow stuff, #24519 . Is RTC but seems to be more complicated than my way. But maybe it's the more correct way? Anyway. Is RTC => someone merge.

@infograf768 As @wilsonge commented here infograf768#55 (comment), my PR infograf768#55 seems to be ok. Do you want to merge it into this PR so it can be tested?

even if, apart wilsonge thinking,
i second this
?

I haven’t tested it but if it works it’s definitely the better fix to use the post install cleanup and the built in library

Post install cleanup?

How is the post install cleanup related to this here?

I meant the cleanupPostBatchCopy method :)

Ah now I understand.

Was confused because there is also a cleanup of post install messages issue ;-)

Where do we stand here?

@infograf768 As said above: Merge my PR for you, change title and description of this PR here so it‘s clear that it solves the issue with batch copying articles in general, also if not featured, then refer to this PR here in Brian‘s issue and finally wait for testers.

@richard67
Done.

@infograf768 Now it needs to change title and description of this PR so it is clear that it solves the issue with batch copying articles in general, also if not featured. I can't do this for you now because am at work. I'll leave a reference to this PR in Brian's issue.

I've left a reference comment in PR #24519 that this PR here does the same but in a mroe elegant way.

I've also left comments in issues #24478 and #27060 that this PR here solves these issues.

@SharkyKZ @alikon
Please test again.

I have tested this item ✅ successfully on fc0d70a

I have tested this item ✅ successfully on fc0d70a

RTC

Thanks!